Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 13:43:11 -0300
From:   Arnaldo Carvalho de Melo <acme@kernel.org>
To:     Jiri Olsa <jolsa@redhat.com>
Cc:     Jin Yao <yao.jin@linux.intel.com>, jolsa@kernel.org,
        peterz@infradead.org, mingo@redhat.com,
        alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
        ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2] perf evsel: Adjust hybrid event and global event
 mixed group
Message-ID: <YMJBH6Os6IgE9NYh@kernel.org>
References: <20210609044555.27180-1-yao.jin@linux.intel.com>
 <YMEhYYwQaT5i9/UE@krava>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YMEhYYwQaT5i9/UE@krava>
Precedence: bulk

Em Wed, Jun 09, 2021 at 10:15:29PM +0200, Jiri Olsa escreveu:
> On Wed, Jun 09, 2021 at 12:45:55PM +0800, Jin Yao wrote:
> > A group mixed with hybrid event and global event is allowed. For example,
> > group leader is 'intel_pt//' and the group member is 'cpu_atom/cycles/'.
> > 
> > e.g.
> > perf record --aux-sample -e '{intel_pt//,cpu_atom/cycles/}:u'
> > 
> > The challenge is their available cpus are not fully matched. For example,
> > 'intel_pt//' is available on CPU0-CPU23, but 'cpu_atom/cycles/' is
> > available on CPU16-CPU23.
> > 
> > When getting the group id for group member, we must be very careful.
> > Because the cpu for 'intel_pt//' is not equal to the cpu for
> > 'cpu_atom/cycles/'. Actually the cpu here is the index of evsel->core.cpus,
> > not the real CPU ID.

<SNIP>

> > Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
 
> looks good to me
 
> Acked-by: Jiri Olsa <jolsa@kernel.org>

Thanks, applied.

- Arnaldo