Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp667814pxj; Thu, 10 Jun 2021 09:47:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx54zDpvHAxj9FDmVC3WQnqNU8zZYlzdyNu8mWe4LvceqWZ771g6/j7UnCJgBeOMcY+c2re X-Received: by 2002:a17:906:944a:: with SMTP id z10mr510717ejx.224.1623343636361; Thu, 10 Jun 2021 09:47:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623343636; cv=none; d=google.com; s=arc-20160816; b=vFJiFqY0VQPSoyllXxFXUXszHZWqUYIQnb6nofM7bk81QCousudDwkePjsYhk/4LEz Q7CtXzTXzGRCp2UEW6gznA77zlye212cfcmnEDvlo1PctlK1sqBqpX5eFdj5Tf/abjl+ vJqNwKC6FoLBXgdL7n3+AG2B+HsjnfjvqHkDcVGy3sZIn+JHyIUHuLPk9Mr5Lb1XxBrA eGbwaigC8G3UH/Km1WIp09G2x7En+zKvb2dQcMzTpqtYAAUdKmKOBj+qvEnjuRqs1uwl uYiV0+QKFg0e7oisisIaS2uOOpQ/Ja0lWlv+TmIdRv/yI2oGplaGdwmxySwpbEWbu+1e T1qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=cP6G4cxMVx0EwF3yOM58gwJwnU2DrynFPBO8vVoT25c=; b=wQO9OB/zxEGxg/X7exUesdbF7xaCS8y9ykC3HIPVKxAPXwNStN2ThzdHPshE3l4Cj8 6tj+D73uyo7cXJg/tF0eCRBO9IcpRtI6hGJbD4PzPSbMUNYRccqK1jy7KgpzLQSu/oNW s2oAMOBpyWRLi2qixqdPNUEfB4FNqdswSFf59jUtVnWtp01PxBrqcPR/lhcjJZSikCON AjyHJQoRmdMnzTVXuDIm0vanzMhY0kthSx5LEiIhGUxGob47HMFuOYgMRBsH/Ykce5oR 1rLKl30yKy7dC+fnry2p1PL2z5MfzvRLQuvGXXQr2+BXbJxV2/+I6BivoI08F03HthG1 C7cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si2565158eji.562.2021.06.10.09.46.52; Thu, 10 Jun 2021 09:47:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231455AbhFJQrv (ORCPT + 99 others); Thu, 10 Jun 2021 12:47:51 -0400 Received: from mail-pg1-f178.google.com ([209.85.215.178]:46038 "EHLO mail-pg1-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230262AbhFJQru (ORCPT ); Thu, 10 Jun 2021 12:47:50 -0400 Received: by mail-pg1-f178.google.com with SMTP id q15so210651pgg.12; Thu, 10 Jun 2021 09:45:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=cP6G4cxMVx0EwF3yOM58gwJwnU2DrynFPBO8vVoT25c=; b=c3qrFcPCAWuk1SwAh3onzp9n8U/GlwRQg3g13dEyS3wrQrLEHh+maT35240/HfR3so STPYTZI5257WpAh41SQl26oXE6+wuxb9+YGJgiUG3Dovz4xtMm3/9hyQlNynVG5adULR J0yX4T+CVwUI5hcJaFn1CwUhAuy51iq9WIPe5IvuGPcsUfvUDciR5GSyjK1dWANlvzFZ t/N/PutuHRPSDa3KvVHcDQHbsasG6huDI8WHzlBLaifbnq/SgKYbE+DwRCVxoLeNtm5M BcXP91g6xrqBdXzwBMq+7LEu9XDdKzngfgJSRZqiAnCapxkwUeS1Tk9x6YkVAICW32uz VlvQ== X-Gm-Message-State: AOAM530ugiyCbhL0GfrEu/Uxqd918RdVALZmYxjG5Qv1keWe01uAQJv1 /Oe4D4Dm3yOAn3q3w98j7+E= X-Received: by 2002:aa7:8431:0:b029:2e9:dcb1:148f with SMTP id q17-20020aa784310000b02902e9dcb1148fmr3864748pfn.29.1623343553489; Thu, 10 Jun 2021 09:45:53 -0700 (PDT) Received: from [192.168.3.217] (c-73-241-217-19.hsd1.ca.comcast.net. [73.241.217.19]) by smtp.gmail.com with ESMTPSA id k9sm3069519pgq.27.2021.06.10.09.45.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 09:45:52 -0700 (PDT) Subject: Re: [PATCH v36 1/4] scsi: ufs: Introduce HPB feature To: daejun7.park@samsung.com, Greg KH , "avri.altman@wdc.com" , "jejb@linux.ibm.com" , "martin.petersen@oracle.com" , "asutoshd@codeaurora.org" , "stanley.chu@mediatek.com" , "cang@codeaurora.org" , "huobean@gmail.com" , ALIM AKHTAR Cc: "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , JinHwan Park , Javier Gonzalez , Sung-Jun Park , Jinyoung CHOI , Dukhyun Kwon , Keoseong Park , Jaemyung Lee , Jieon Seol References: <20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p2> <20210607041755epcms2p271195b24f4a10e777d240ff5d844168f@epcms2p2> From: Bart Van Assche Message-ID: <5694e1e0-1c8c-12ef-3215-3d3413a86ea2@acm.org> Date: Thu, 10 Jun 2021 09:45:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210607041755epcms2p271195b24f4a10e777d240ff5d844168f@epcms2p2> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/6/21 9:17 PM, Daejun Park wrote: > +What: /sys/class/scsi_device/*/device/hpb_sysfs/hit_cnt > +Date: June 2021 > +Contact: Daejun Park > +Description: This entry shows the number of reads that changed to HPB read. > + > + The file is read only. This patch introduces the hit_cnt attribute in the hpb_sysfs directory and patch 4 moves that attribute to the hpb_stats directory. That is not how sysfs attributes should be introduced. Please introduce the hit_cnt attribute in the hpb_stats directory in this patch such that the sysfs directory does not have to be modified in patch 4. Thanks, Bart.