Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 11:10:52 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Cc:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Ohad Ben-Cohen <ohad@wizery.com>,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com
Subject: Re: [PATCH] rpmsg: Fix rpmsg_create_ept return when RPMSG config is
 not defined
Message-ID: <20210610171052.GF34238@p14s>
References: <20210604160549.2122-1-arnaud.pouliquen@foss.st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210604160549.2122-1-arnaud.pouliquen@foss.st.com>
Precedence: bulk

On Fri, Jun 04, 2021 at 06:05:49PM +0200, Arnaud Pouliquen wrote:
> This is a minor fix.
> 
> According to the description of the rpmsg_create_ept in rpmsg_core.c
> the function should return NULL on error.
> 

You are correct, and none of the client return an error code either.

> Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
> ---
>  include/linux/rpmsg.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/rpmsg.h b/include/linux/rpmsg.h
> index d97dcd049f18..a8dcf8a9ae88 100644
> --- a/include/linux/rpmsg.h
> +++ b/include/linux/rpmsg.h
> @@ -231,7 +231,7 @@ static inline struct rpmsg_endpoint *rpmsg_create_ept(struct rpmsg_device *rpdev
>  	/* This shouldn't be possible */
>  	WARN_ON(1);
>  
> -	return ERR_PTR(-ENXIO);
> +	return NULL;

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>  }
>  
>  static inline int rpmsg_send(struct rpmsg_endpoint *ept, void *data, int len)
> -- 
> 2.17.1
>