Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Thu, 10 Jun 2021 14:11:42 -0700 (PDT)
Message-Id: <20210610.141142.1384244468678097702.davem@davemloft.net>
To:     hbut_tan@163.com
Cc:     elder@kernel.org, kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, tanzhongjun@yulong.com
Subject: Re: [PATCH] soc: qcom: ipa: Remove superfluous error message
 around platform_get_irq()
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20210610140118.1437-1-hbut_tan@163.com>
References: <20210610140118.1437-1-hbut_tan@163.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: ?Zhongjun Tan <hbut_tan@163.com>
Date: Thu, 10 Jun 2021 22:01:18 +0800

> diff --git a/drivers/net/ipa/ipa_smp2p.c b/drivers/net/ipa/ipa_smp2p.c
> index 34b68dc43886..93270e50b6b3 100644
> --- a/drivers/net/ipa/ipa_smp2p.c
> +++ b/drivers/net/ipa/ipa_smp2p.c
> @@ -177,11 +177,8 @@ static int ipa_smp2p_irq_init(struct ipa_smp2p *smp2p, const char *name,
>  	int ret;
>  
>  	ret = platform_get_irq_byname(smp2p->ipa->pdev, name);
> -	if (ret <= 0) {
> -		dev_err(dev, "DT error %d getting \"%s\" IRQ property\n",
> -			ret, name);
> +	if (ret <= 0)
Applied, but this code still rejects an irq of zero which is a valid irq number.