Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <e9849007-8169-cb32-b0f1-5be6210f1319@geanix.com>
References: <20210610071758.1560592-1-sean@geanix.com> <e9849007-8169-cb32-b0f1-5be6210f1319@geanix.com>
Subject: Re: [PATCH] clk: fix possible circular locking in clk_notifier_register()
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Michael Turquette <mturquette@baylibre.com>,
        Sean Nyekjaer <sean@geanix.com>
Date:   Thu, 10 Jun 2021 14:18:14 -0700
Message-ID: <162335989440.9598.5831025849742947247@swboyd.mtv.corp.google.com>
User-Agent: alot/0.9.1
Precedence: bulk

Quoting Sean Nyekjaer (2021-06-10 00:23:30)
> On 10/06/2021 09.17, Sean Nyekjaer wrote:
> > Allocating memory with prepare_lock mutex held makes lockdep unhappy
> > when memory pressure makes the system do fs_reclaim on eg. rawnand using
> > clk.
> >=20
> > Push the allocation outside the lock.
> >=20
> [...]
> >=20
> > Signed-off-by: Sean Nyekjaer <sean@geanix.com>
> Fixes: b2476490ef111 ("clk: introduce the common clock framework")
>=20
> We could possibly add this fixes tag ^^

Sure.