Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210608230929.GA1214@raspberrypi> <CAJ-EccMvTNpnZXAF6n2x7oXu_hsSOnbJvvQA6NsK1VG26t5CeQ@mail.gmail.com>
In-Reply-To: <CAJ-EccMvTNpnZXAF6n2x7oXu_hsSOnbJvvQA6NsK1VG26t5CeQ@mail.gmail.com>
From:   Austin Kim <austindh.kim@gmail.com>
Date:   Fri, 11 Jun 2021 07:33:23 +0900
Message-ID: <CADLLry6p+NvQFqXSunZ645DiRYSAsuT5vMe6F2Tofj8+Dcrxyw@mail.gmail.com>
Subject: Re: [PATCH] LSM: SafeSetID: Mark safesetid_initialized as __initdata
To:     Micah Morton <mortonm@chromium.org>
Cc:     James Morris <jmorris@namei.org>,
        "Serge E. Hallyn" <serge@hallyn.com>,
        linux-security-module <linux-security-module@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?6rmA64+Z7ZiE?= <austin.kim@lge.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021=EB=85=84 6=EC=9B=94 11=EC=9D=BC (=EA=B8=88) =EC=98=A4=EC=A0=84 1:50, M=
icah Morton <mortonm@chromium.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:
>
> Thanks for the patch. Looks right, since that variable is only used in
> safesetid_security_init() and safesetid_init_securityfs(), which are
> both marked __init. I can merge it to the safesetid-next branch today
> and send the patch through my tree during the 5.14 merge window.

Great. Thanks!

>
> On Tue, Jun 8, 2021 at 1:09 PM Austin Kim <austindh.kim@gmail.com> wrote:
> >
> > Mark safesetid_initialized as __initdata since it is only used
> > in initialization routine.
> >
> > Signed-off-by: Austin Kim <austindh.kim@gmail.com>
> > ---
> >  security/safesetid/lsm.c | 2 +-
> >  security/safesetid/lsm.h | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/security/safesetid/lsm.c b/security/safesetid/lsm.c
> > index 1079c6d54784..963f4ad9cb66 100644
> > --- a/security/safesetid/lsm.c
> > +++ b/security/safesetid/lsm.c
> > @@ -22,7 +22,7 @@
> >  #include "lsm.h"
> >
> >  /* Flag indicating whether initialization completed */
> > -int safesetid_initialized;
> > +int safesetid_initialized __initdata;
> >
> >  struct setid_ruleset __rcu *safesetid_setuid_rules;
> >  struct setid_ruleset __rcu *safesetid_setgid_rules;
> > diff --git a/security/safesetid/lsm.h b/security/safesetid/lsm.h
> > index bde8c43a3767..d346f4849cea 100644
> > --- a/security/safesetid/lsm.h
> > +++ b/security/safesetid/lsm.h
> > @@ -19,7 +19,7 @@
> >  #include <linux/hashtable.h>
> >
> >  /* Flag indicating whether initialization completed */
> > -extern int safesetid_initialized;
> > +extern int safesetid_initialized __initdata;
> >
> >  enum sid_policy_type {
> >         SIDPOL_DEFAULT, /* source ID is unaffected by policy */
> > --
> > 2.20.1
> >