Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp88949pxj; Thu, 10 Jun 2021 15:43:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw2IcQ5cwJrFZrmWmfW21nLTHaCC7ub7T7leDDCxqkIqKBTi9sgTHzIfLlGww88MQzkVxt4 X-Received: by 2002:aa7:c647:: with SMTP id z7mr710244edr.224.1623365015292; Thu, 10 Jun 2021 15:43:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623365015; cv=none; d=google.com; s=arc-20160816; b=avH9xVxSA1PJ+4x0AOFaUy/wQsN1hYOqmC6KbQmJdRSH8dxA7MFoRRhcH5tzwqhzpG sK6SH6H0d4vzJUSffoCFmkj3RVqW6gU9tFdF/LHIBFAjVTKpxwmQRvqJCJWpp+/lI5a1 6x8A4om9wAtu3l5jzMM+HeHYJF0DFadXLjc2aLq1PkYeQ4+oKWY5yM3x4/mueuUJrkBG weeQBTeCE7Gt0Gz3wVCcSAIbm3Ul17NDrtIqkGcOAPMDktoy7cb1GaVc0bmM6YBkfHEV nwr4JFDdrh7CpCuHzDWmHMekovm1qpUhYh+BUVbU73gGtzl7GK8ys6S85NsRuZXPHOD3 JD/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4CA8z+dDu7d9proABF9lM5G9ph/TFB0T/NCi5liIvic=; b=OQi3CVv7xaQZprBwAHEnSXRfiQnhYWDk5vH2wUiVM6pwS+rgbLyphMu1YYPoDJ8fvF R1Ow3xh9MOBarNhG8ilRbPgDoA4ZYrtcNRok8+ctrnWzjId1STatXgWKqQyoWUy2qLRx SNl2j9tdVORHsWmkHHKP0GCJWdjPH65QfB+6clCHY+s1H8yuYdpTcgA6oXAXre7QEmAg j2Ly9HYxTE/aW8ucbh8qdPAn1JOK6TRq/YX5GNeCSQla/3zP9x4qUJ0Zran6wGLXZ125 TsFo38hsMpaqGwPFmDq82ABl8w9Y2X4OwN7lCZv/rRDiYoqLR5QZ29DNTN0HLLs6G4/0 l+tw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amazon.co.jp header.s=amazon201209 header.b=fPAWlycN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.co.jp Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f17si3382554eds.78.2021.06.10.15.43.10; Thu, 10 Jun 2021 15:43:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@amazon.co.jp header.s=amazon201209 header.b=fPAWlycN; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amazon.co.jp Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230248AbhFJWl5 (ORCPT + 99 others); Thu, 10 Jun 2021 18:41:57 -0400 Received: from smtp-fw-6001.amazon.com ([52.95.48.154]:10363 "EHLO smtp-fw-6001.amazon.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230001AbhFJWl5 (ORCPT ); Thu, 10 Jun 2021 18:41:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.co.jp; i=@amazon.co.jp; q=dns/txt; s=amazon201209; t=1623364802; x=1654900802; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=4CA8z+dDu7d9proABF9lM5G9ph/TFB0T/NCi5liIvic=; b=fPAWlycNgUIN1O5AaRfDUGDhDOJf6nYcuFL3dcFoLvrkHjqhkDQedK8y 3qPcDVokP0y0s1vIjSZwFD1jvSDs7u16dGsckNSD9WXNwvFqqPYMLXlDs oG4efk+0/BSWGntadZnWE4ZFKDmzuVy+cTk0SdFmvo4uIffzGnKwChs/F w=; X-IronPort-AV: E=Sophos;i="5.83,264,1616457600"; d="scan'208";a="119476266" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO email-inbound-relay-2b-4ff6265a.us-west-2.amazon.com) ([10.43.8.6]) by smtp-border-fw-6001.iad6.amazon.com with ESMTP; 10 Jun 2021 22:40:00 +0000 Received: from EX13MTAUWB001.ant.amazon.com (pdx1-ws-svc-p6-lb9-vlan3.pdx.amazon.com [10.236.137.198]) by email-inbound-relay-2b-4ff6265a.us-west-2.amazon.com (Postfix) with ESMTPS id 2783CA231F; Thu, 10 Jun 2021 22:39:58 +0000 (UTC) Received: from EX13D04ANC001.ant.amazon.com (10.43.157.89) by EX13MTAUWB001.ant.amazon.com (10.43.161.249) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 10 Jun 2021 22:39:57 +0000 Received: from 88665a182662.ant.amazon.com (10.43.161.183) by EX13D04ANC001.ant.amazon.com (10.43.157.89) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Thu, 10 Jun 2021 22:39:53 +0000 From: Kuniyuki Iwashima To: CC: , , , , , , , , , , , , Subject: Re: [PATCH v7 bpf-next 04/11] tcp: Add reuseport_migrate_sock() to select a new listener. Date: Fri, 11 Jun 2021 07:39:49 +0900 Message-ID: <20210610223949.98599-1-kuniyu@amazon.co.jp> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.43.161.183] X-ClientProxiedBy: EX13D42UWB001.ant.amazon.com (10.43.161.35) To EX13D04ANC001.ant.amazon.com (10.43.157.89) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Eric Dumazet Date: Thu, 10 Jun 2021 20:09:32 +0200 > On 5/21/21 8:20 PM, Kuniyuki Iwashima wrote: > > reuseport_migrate_sock() does the same check done in > > reuseport_listen_stop_sock(). If the reuseport group is capable of > > migration, reuseport_migrate_sock() selects a new listener by the child > > socket hash and increments the listener's sk_refcnt beforehand. Thus, if we > > fail in the migration, we have to decrement it later. > > > > We will support migration by eBPF in the later commits. > > > > Signed-off-by: Kuniyuki Iwashima > > Signed-off-by: Martin KaFai Lau > > --- > > include/net/sock_reuseport.h | 3 ++ > > net/core/sock_reuseport.c | 78 +++++++++++++++++++++++++++++------- > > 2 files changed, 67 insertions(+), 14 deletions(-) > > Reviewed-by: Eric Dumazet Thank you again!