Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v36 1/4] scsi: ufs: Introduce HPB feature
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Bart Van Assche <bvanassche@acm.org>,
        Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        ALIM AKHTAR <alim.akhtar@samsung.com>
CC:     "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
In-Reply-To: <5694e1e0-1c8c-12ef-3215-3d3413a86ea2@acm.org>
Message-ID: <20210611002837epcms2p672829dbecc175ef8cb2428ebf36e8cae@epcms2p6>
Date:   Fri, 11 Jun 2021 09:28:37 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <5694e1e0-1c8c-12ef-3215-3d3413a86ea2@acm.org>
        <20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p2>
        <20210607041755epcms2p271195b24f4a10e777d240ff5d844168f@epcms2p2>
        <CGME20210607041650epcms2p29002c9d072738bbf21fb4acf31847e8e@epcms2p6>
Precedence: bulk

Hi,

>On 6/6/21 9:17 PM, Daejun Park wrote:
>> +What:                /sys/class/scsi_device/*/device/hpb_sysfs/hit_cnt
>> +Date:                June 2021
>> +Contact:        Daejun Park <daejun7.park@samsung.com>
>> +Description:        This entry shows the number of reads that changed to HPB read.
>> +
>> +                The file is read only.
> 
>This patch introduces the hit_cnt attribute in the hpb_sysfs directory
>and patch 4 moves that attribute to the hpb_stats directory. That is not
>how sysfs attributes should be introduced. Please introduce the hit_cnt
>attribute in the hpb_stats directory in this patch such that the sysfs
>directory does not have to be modified in patch 4.
Sure, Sure, I will prepare this in the next patch.

Thanks,
Daejun

> 
>Thanks,
> 
>Bart.
> 
> 
>