Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] btrfs: send: use list_move_tail instead of
 list_del/list_add_tail
To:     <dsterba@suse.cz>, Anand Jain <anand.jain@oracle.com>,
        <linux-kernel@vger.kernel.org>, Chris Mason <clm@fb.com>,
        Josef Bacik <josef@toxicpanda.com>,
        David Sterba <dsterba@suse.com>, <weiyongjun1@huawei.com>,
        <yuehaibing@huawei.com>, <yangjihong1@huawei.com>,
        <yukuai3@huawei.com>, <linux-btrfs@vger.kernel.org>,
        <kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
References: <20210608031220.2822257-1-libaokun1@huawei.com>
 <e860684e-959b-d126-bb1d-3214878ab995@oracle.com>
 <20210608141233.GQ31483@twin.jikos.cz>
From:   "libaokun (A)" <libaokun1@huawei.com>
Message-ID: <f7bea721-cda5-0b20-13e3-28c4bd728063@huawei.com>
Date:   Fri, 11 Jun 2021 14:05:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <20210608141233.GQ31483@twin.jikos.cz>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

Thank you for your advice.

I'm about to send a patch v2 with the changes suggested by you.

Best Regards


?? 2021/6/8 22:12, David Sterba д??:
> On Tue, Jun 08, 2021 at 01:16:21PM +0800, Anand Jain wrote:
>> On 8/6/21 11:12 am, Baokun Li wrote:
>>> Using list_move_tail() instead of list_del() + list_add_tail().
>>>
>>> Reported-by: Hulk Robot <hulkci@huawei.com>
>>> Signed-off-by: Baokun Li <libaokun1@huawei.com>
>>> ---
>>>    fs/btrfs/send.c | 3 +--
>>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
>>> index bd69db72acc5..a0e51b2416a1 100644
>>> --- a/fs/btrfs/send.c
>>> +++ b/fs/btrfs/send.c
>>> @@ -2083,8 +2083,7 @@ static struct name_cache_entry *name_cache_search(struct send_ctx *sctx,
>>>     */
>>>    static void name_cache_used(struct send_ctx *sctx, struct name_cache_entry *nce)
>>>    {
>>> -	list_del(&nce->list);
>>> -	list_add_tail(&nce->list, &sctx->name_cache_list);
>>> +	list_move_tail(&nce->list, &sctx->name_cache_list);
>>>    }
>>
>>    Looks good.
>>    You can consider open-code name_cache_used() as there is only one user.
> Yeah sounds like a good idea, with part of the function comment next to
> the list_move_tail.
> .