Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: meson: vim3: reduce cpu thermal fan trigger
 temperature
To:     xieqinick@gmail.com, robh+dt@kernel.org, khilman@baylibre.com,
        jbrunet@baylibre.com, martin.blumenstingl@googlemail.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Cc:     nick@khadas.com, artem@khadas.com
References: <20210609012849.797576-1-xieqinick@gmail.com>
From:   Neil Armstrong <narmstrong@baylibre.com>
Organization: Baylibre
Message-ID: <11da3ae4-91d4-1e51-c652-e4ad518f13bd@baylibre.com>
Date:   Fri, 11 Jun 2021 08:44:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210609012849.797576-1-xieqinick@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Nick,

On 09/06/2021 03:28, xieqinick@gmail.com wrote:
> From: Nick Xie <nick@khadas.com>
> 
> Reduce the MCU FAN trigger temperature from
> 80 degree centigrade to 50 degree centigrade.

Can you add some more rationale to this change ?

> 
> Signed-off-by: Nick Xie <nick@khadas.com>
> ---
>  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 66d67524b031..a9c34fee91f4 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -256,7 +256,7 @@ &cecb_AO {
>  &cpu_thermal {
>  	trips {
>  		cpu_active: cpu-active {
> -			temperature = <80000>; /* millicelsius */
> +			temperature = <50000>; /* millicelsius */
>  			hysteresis = <2000>; /* millicelsius */
>  			type = "active";
>  		};
> 

With that:
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>