Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210609012849.797576-1-xieqinick@gmail.com> <11da3ae4-91d4-1e51-c652-e4ad518f13bd@baylibre.com>
 <CAP4nuTVMZV7pz8NrM2MHcZzBdueRXjS+KYsU4=cQ1CB67gr_Hg@mail.gmail.com> <ee3341d9-350e-a84d-6836-3401be679b2a@baylibre.com>
In-Reply-To: <ee3341d9-350e-a84d-6836-3401be679b2a@baylibre.com>
From:   Nick Xie <xieqinick@gmail.com>
Date:   Fri, 11 Jun 2021 15:30:33 +0800
Message-ID: <CAP4nuTUt1vQjVP=3_NYaeu+m47f78ru6-MgGBiAqLeU9fJAsNg@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: meson: vim3: reduce cpu thermal fan trigger temperature
To:     Neil Armstrong <narmstrong@baylibre.com>
Cc:     robh+dt@kernel.org, khilman@baylibre.com, jbrunet@baylibre.com,
        martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Nick <nick@khadas.com>, artem@khadas.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hello Neil,


Neil Armstrong <narmstrong@baylibre.com> =E4=BA=8E2021=E5=B9=B46=E6=9C=8811=
=E6=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=E5=8D=883:15=E5=86=99=E9=81=93=EF=BC=
=9A
>
> Hi,
>
> On 11/06/2021 08:54, Nick Xie wrote:
> > Hello Neil,
> >
> > The MCU FAN won't work until the temperature reach to 80 degree centigr=
ade,
> > Do you think the temperature is too high?
>
> I think 80 is tool high, but I fear 50 is way too low, but if you think 5=
0 is OK after you ran some tests, just add it to the commit log and it's ok=
 for me.

I think it is OK, we use it for a long time.

Thanks.

>
> Neil
>
> >
> > Thanks.
> >
> > Neil Armstrong <narmstrong@baylibre.com <mailto:narmstrong@baylibre.com=
>> =E4=BA=8E2021=E5=B9=B46=E6=9C=8811=E6=97=A5=E5=91=A8=E4=BA=94 =E4=B8=8B=
=E5=8D=882:44=E5=86=99=E9=81=93=EF=BC=9A
> >
> >     Hi Nick,
> >
> >     On 09/06/2021 03:28, xieqinick@gmail.com <mailto:xieqinick@gmail.co=
m> wrote:
> >     > From: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>>
> >     >
> >     > Reduce the MCU FAN trigger temperature from
> >     > 80 degree centigrade to 50 degree centigrade.
> >
> >     Can you add some more rationale to this change ?
> >
> >     >
> >     > Signed-off-by: Nick Xie <nick@khadas.com <mailto:nick@khadas.com>=
>
> >     > ---
> >     >  arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 2 +-
> >     >  1 file changed, 1 insertion(+), 1 deletion(-)
> >     >
> >     > diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b=
/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> >     > index 66d67524b031..a9c34fee91f4 100644
> >     > --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> >     > +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> >     > @@ -256,7 +256,7 @@ &cecb_AO {
> >     >  &cpu_thermal {
> >     >       trips {
> >     >               cpu_active: cpu-active {
> >     > -                     temperature =3D <80000>; /* millicelsius */
> >     > +                     temperature =3D <50000>; /* millicelsius */
> >     >                       hysteresis =3D <2000>; /* millicelsius */
> >     >                       type =3D "active";
> >     >               };
> >     >
> >
> >     With that:
> >     Reviewed-by: Neil Armstrong <narmstrong@baylibre.com <mailto:narmst=
rong@baylibre.com>>
> >
>