Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH net-next v2] net: mdio: mscc-miim: Use
 devm_platform_get_and_ioremap_resource()
To:     "weiyongjun (A)" <weiyongjun1@huawei.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
CC:     "davem@davemloft.net" <davem@davemloft.net>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "andrew@lunn.ch" <andrew@lunn.ch>
References: <20210611045049.3905429-1-yangyingliang@huawei.com>
 <72e99523-b1f0-bff4-ad96-0d71b3901480@huawei.com>
From:   Yang Yingliang <yangyingliang@huawei.com>
Message-ID: <6e467434-7d38-7810-03fb-c884447f3d75@huawei.com>
Date:   Fri, 11 Jun 2021 15:40:22 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <72e99523-b1f0-bff4-ad96-0d71b3901480@huawei.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk


On 2021/6/11 14:57, weiyongjun (A) wrote:
>
>> Use devm_platform_get_and_ioremap_resource() to simplify
>> code.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> v2:
>>    only convert the first platform_get_resource()
>> ---
>>   drivers/net/mdio/mdio-mscc-miim.c | 6 +-----
>>   1 file changed, 1 insertion(+), 5 deletions(-)
>>
>> diff --git a/drivers/net/mdio/mdio-mscc-miim.c 
>> b/drivers/net/mdio/mdio-mscc-miim.c
>> index b36e5ea04ddf..071c654bab29 100644
>> --- a/drivers/net/mdio/mdio-mscc-miim.c
>> +++ b/drivers/net/mdio/mdio-mscc-miim.c
>> @@ -139,10 +139,6 @@ static int mscc_miim_probe(struct 
>> platform_device *pdev)
>>       struct mscc_miim_dev *dev;
>>       int ret;
>>   -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> -    if (!res)
>> -        return -ENODEV;
>> -
>>       bus = devm_mdiobus_alloc_size(&pdev->dev, sizeof(*dev));
>>       if (!bus)
>>           return -ENOMEM;
>> @@ -155,7 +151,7 @@ static int mscc_miim_probe(struct platform_device 
>> *pdev)
>>       bus->parent = &pdev->dev;
>>         dev = bus->priv;
>> -    dev->regs = devm_ioremap_resource(&pdev->dev, res);
>> +    dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, &res);
>
>
> res not used later, so should be
>
> dev->regs = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
Yes, I will send a v3 later.

Thanks,
Yang
>
>
>>       if (IS_ERR(dev->regs)) {
>>           dev_err(&pdev->dev, "Unable to map MIIM registers\n");
>>           return PTR_ERR(dev->regs);
> .