Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v9 1/5] nvmem: prepare basics for FRAM support
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Christian Eggers <ceggers@arri.de>,
        Arnd Bergmann <arnd@arndb.de>
References: <20210611052652.7894-1-jiri.prchal@aksignal.cz>
 <20210611052652.7894-2-jiri.prchal@aksignal.cz> <YMMjbCFzsfiT8dMA@kroah.com>
From:   =?UTF-8?B?SmnFmcOtIFByY2hhbA==?= <jiri.prchal@aksignal.cz>
Message-ID: <3c2beca6-8ef5-834d-a37a-5aea53bc1305@aksignal.cz>
Date:   Fri, 11 Jun 2021 10:59:07 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YMMjbCFzsfiT8dMA@kroah.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11. 06. 21 10:48, Greg Kroah-Hartman wrote:
> On Fri, Jun 11, 2021 at 07:26:48AM +0200, Jiri Prchal wrote:
>> Added enum and string for FRAM to expose it as "fram".
> 
> I have no idea what "FRAM" is, nor what "fram" is.
> 
> And why do you not add the documentation update here in this same
> commit?  This is where you are adding it, trying to dig later in the
> series to notice that you really did provide this is a pain, and is
> harder to track.
> 
> Please provide more information here in the changelog and move the
> Documentation addition here into this patch.

Should I also join #1 and 2 together?