Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp425756pxj; Fri, 11 Jun 2021 02:37:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxMvfdNy3DV0XRVkwzEIXG/7/CQE+2hF0RXbHAjdyBKMAo36HWefxxR+X8R3U5O4dNqF3LQ X-Received: by 2002:a17:907:1009:: with SMTP id ox9mr2888352ejb.292.1623404270198; Fri, 11 Jun 2021 02:37:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623404270; cv=none; d=google.com; s=arc-20160816; b=mbisRK5q20YJ3CvJmHkdoM1EndxeGephtNiZSSDDwmmzRWSH/10ozhkh8OslDiJHZ7 7ui5L582kvXQqdzXJa4V23qTOOlae3pEeNInR9w0Cpw/m/bBVvecvJ2ZMzY4b7yldxYY i67WvKcmOTvVG5Qu2rPoqhK2ldO9SdWoauEyWbQGJQCGR65cPATAxadYfSqyIR8Imsy5 Poy3a4AsgSFLqZ76i9nNrclqOXCe72s6Z5729D1XcK96Dy5QZcnYgGFvj2PKlZNC/cs3 mh49nd9v0diBUoTRLhMTTNojz4H8oOWZXa29O6TXhRK7kCS7uZ6ZpkCVvjlcmsJxSJwB NmkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=swTzG5VLmQN7FCMG1PpJaYoi9kNHihcrB4vwa1loN5s=; b=ARFEvgMgHCGdTKZmdbHcUqsHLgY2+RzzVV0aIzy88U0cNqAzgmUAZDt2B0LS77vOgt AFrY/4fxrEJIWtAys7gux4VfwCM6PtF3s+6cngavVThEEn4BHyo6UgyTmQitFpYsyNHy FXGQdBBjNQaPYHzHcNjEXlDJChA/5vOo62FroxEhmTXRrx2U7QYRZ0NgRzsUhaYkZ9jz jnWleNIm27ktdnB5NHOxqYRIi8vJhNbfpulynbGdbdQ34iZhy7iABFE2fNZvemVWT2ka vCmKq+CQzy6AfleIgmuwDcHw3wFIa7HlN8FRKNkGk+/LqfvbH0QkZjnBQdvHbj5Y2EEc Tftw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb13si5180714edb.312.2021.06.11.02.37.26; Fri, 11 Jun 2021 02:37:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231628AbhFKJez (ORCPT + 99 others); Fri, 11 Jun 2021 05:34:55 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:3966 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231361AbhFKJed (ORCPT ); Fri, 11 Jun 2021 05:34:33 -0400 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.56]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G1bCD0Sgkz6w0y; Fri, 11 Jun 2021 17:29:28 +0800 (CST) Received: from dggpeml500017.china.huawei.com (7.185.36.243) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 11 Jun 2021 17:32:33 +0800 Received: from huawei.com (10.175.103.91) by dggpeml500017.china.huawei.com (7.185.36.243) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Fri, 11 Jun 2021 17:32:33 +0800 From: Yang Yingliang To: , , CC: , Subject: [PATCH -next 9/9] ASoC: fsl_xcvr: check return value after calling platform_get_resource_byname() Date: Fri, 11 Jun 2021 17:36:26 +0800 Message-ID: <20210611093626.579176-10-yangyingliang@huawei.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210611093626.579176-1-yangyingliang@huawei.com> References: <20210611093626.579176-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.103.91] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpeml500017.china.huawei.com (7.185.36.243) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It will cause null-ptr-deref if platform_get_resource_byname() returns NULL, we need check the return value. Signed-off-by: Yang Yingliang --- sound/soc/fsl/fsl_xcvr.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index df7c189d97dd..2e9061c5ed74 100644 --- a/sound/soc/fsl/fsl_xcvr.c +++ b/sound/soc/fsl/fsl_xcvr.c @@ -1202,6 +1202,10 @@ static int fsl_xcvr_probe(struct platform_device *pdev) rx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rxfifo"); tx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "txfifo"); + if (!rx_res || !tx_res) { + dev_err(dev, "Invalid resource\n"); + return -EINVAL; + } xcvr->dma_prms_rx.chan_name = "rx"; xcvr->dma_prms_tx.chan_name = "tx"; xcvr->dma_prms_rx.addr = rx_res->start; -- 2.25.1