Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] firmware: tegra: Fix build error while
 ARCH_TEGRA_234_SOC enabled
To:     <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
        <treding@nvidia.com>
CC:     <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20210611120636.28252-1-yuehaibing@huawei.com>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <708178d9-e842-bac0-2f48-c6ce81aaee54@huawei.com>
Date:   Fri, 11 Jun 2021 20:20:54 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <20210611120636.28252-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Pls ignore this

On 2021/6/11 20:06, YueHaibing wrote:
> drivers/firmware/tegra/bpmp.c:861:51:
>  error: ‘tegra186_soc’ undeclared here (not in a function); did you mean ‘tegra_ivc’?
>   { .compatible = "nvidia,tegra186-bpmp", .data = &tegra186_soc },
>                                                    ^~~~~~~~~~~~
>                                                    tegra_ivc
> 
> Add missing ifdef block to fix this.
> 
> Fixes: 0ebdf11699d0 ("firmware: tegra: Enable BPMP support on Tegra234")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/firmware/tegra/bpmp.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
> index 0742a90cb844..5654c5e9862b 100644
> --- a/drivers/firmware/tegra/bpmp.c
> +++ b/drivers/firmware/tegra/bpmp.c
> @@ -809,7 +809,8 @@ static const struct dev_pm_ops tegra_bpmp_pm_ops = {
>  };
>  
>  #if IS_ENABLED(CONFIG_ARCH_TEGRA_186_SOC) || \
> -    IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC)
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_194_SOC) || \
> +    IS_ENABLED(CONFIG_ARCH_TEGRA_234_SOC)
>  static const struct tegra_bpmp_soc tegra186_soc = {
>  	.channels = {
>  		.cpu_tx = {
>