Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp570136pxj; Fri, 11 Jun 2021 06:17:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzl8qG+IRo2dkavGrI6RSVP67yHmzDBmw4nMm7vQtw6wI7jgQwCgDlaiJFmD6GTx0EbZt5 X-Received: by 2002:a17:906:6899:: with SMTP id n25mr3656603ejr.462.1623417422933; Fri, 11 Jun 2021 06:17:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623417422; cv=none; d=google.com; s=arc-20160816; b=msUMzKykpulMHZg9eqWv6XbeRu3qtJgv4EYQ1q8Tbfvdjca7YWLfOzPizNwD0BUfD+ 5517HHxH9HR70UTwT9tNTyjZdxXKtemcnt9Iow2W6lskcGDB7n9f6U8GsYm/BAbzsESL F2k8IuNCcNiAGmeoGKbQRz2A+P0L3+ZuHZ7I+j7zuaUfYnUT+KFaJmWOHQxGjySZSPRu TYjhoYMG9LEKameDsP2beZgCO+kOMMgGHMiXKMZ6Qh3oz/ZEYdeKiT+knuI8l9t/O90f S2+qFl9lF8vhiu0Mqw5uRmkaGojK0DZJmw8XH27J+H0kS/ijdtaoHrqYXAnvBMsyYPEk Yj6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=W4p7Da6Bo96meqCCmYg1il+szOZMpXmVP32ev1MWjqw=; b=NroN524TZTIyERsK9fT8bCXBk66F/f0iwu1fL75CU/7YEUfej8BRl+SdHXlHQRpx2E e14Vk0RzFvy/VKUq8ltxrwh4n4qsPEbstuGo3RFTeYB92aDJE/wfpOpmQ3adhfp5qLgx dUfQwM25Q3XcBVs0w8RBjsoHi6qbJ3HYt8NF90qVVgDZ2NmaCcvB4D9Cl1QkAP8+DCok N41R8lUcj7K189ApreyIQ0njzCZriZl+/fncVtKHjqowm6CE7RVxWsJjhM311Qct3X92 8GI2UsiY3e2rQ+KfbCDJyQurDT3H5lNS80cjnR0cfwiUP7fyAsyGli7DcWxaAo+vasnR xXoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=Ot4WYiEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a16si4831800eds.411.2021.06.11.06.16.38; Fri, 11 Jun 2021 06:17:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@szeredi.hu header.s=google header.b=Ot4WYiEY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231672AbhFKNR1 (ORCPT + 99 others); Fri, 11 Jun 2021 09:17:27 -0400 Received: from mail-vk1-f181.google.com ([209.85.221.181]:39932 "EHLO mail-vk1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231602AbhFKNR0 (ORCPT ); Fri, 11 Jun 2021 09:17:26 -0400 Received: by mail-vk1-f181.google.com with SMTP id k189so2502641vkb.6 for ; Fri, 11 Jun 2021 06:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=szeredi.hu; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W4p7Da6Bo96meqCCmYg1il+szOZMpXmVP32ev1MWjqw=; b=Ot4WYiEYRIGG3AWEh0UfJ0VBCs67SEfKPGht+bHJknT5g7pwYlgHwxQOciIHRzx08m hIt7/+kXeW2MYUANeixNF4W5KD5kfebehNQo/rfBst3oCwi3WSyG6RpK1tOaGaf/tEsw ZAWXWpBc4AkEFVwaWWEK6gFWoOOSKw571BVes= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W4p7Da6Bo96meqCCmYg1il+szOZMpXmVP32ev1MWjqw=; b=C/lwwvlgbstj8Ti/YEBD0jmLu25ApBn4sQ3OjGz8nK8/nxCZRK3Ycdtg06VPilbZPn /uzKROt9TvrpevtHu4VyE56IMVolAiiYYp/RT7koIbdchq/u1EQ8FGdNn/39KPJnaugL cOYvv7LgSkqcOEOiH0tSFUkGmzzcnI2pRCvd3AxpY2Xax90N5Fjvw4FVngoWvrEJme89 wqeNC9wk30K6W/qsIv3GxYJ2O4Addyc3SPC4MqS5D4KUFm0k4TCViEMAEhh9td6svZHu bam2X52PHPXThseARHK+SwiQzqCbNWHcxlWVdtnCINHh2BeRcMmqgnYaJVrTZurN84Er 7HXg== X-Gm-Message-State: AOAM53263RngDtzSVueWtLqI1NJd27pV5PqTTPHXbqM28F24bOZoSn7r HYj3aQjyN3PdoFYifQstSt5b+mynF0NJ7IUMhcQ+3g== X-Received: by 2002:ac5:c9b5:: with SMTP id f21mr8183303vkm.23.1623417268493; Fri, 11 Jun 2021 06:14:28 -0700 (PDT) MIME-Version: 1.0 References: <162322846765.361452.17051755721944717990.stgit@web.messagingengine.com> <162322874509.361452.3143376113190093370.stgit@web.messagingengine.com> In-Reply-To: <162322874509.361452.3143376113190093370.stgit@web.messagingengine.com> From: Miklos Szeredi Date: Fri, 11 Jun 2021 15:14:17 +0200 Message-ID: Subject: Re: [PATCH v6 7/7] kernfs: dont call d_splice_alias() under kernfs node lock To: Ian Kent Cc: Greg Kroah-Hartman , Tejun Heo , Eric Sandeen , Fox Chen , Brice Goglin , Al Viro , Rick Lindsley , David Howells , Marcelo Tosatti , "Eric W. Biederman" , Carlos Maiolino , linux-fsdevel , Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Jun 2021 at 10:52, Ian Kent wrote: > > The call to d_splice_alias() in kernfs_iop_lookup() doesn't depend on > any kernfs node so there's no reason to hold the kernfs node lock when > calling it. > > Signed-off-by: Ian Kent Reviewed-by: Miklos Szeredi