Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   SeongJae Park <sj38.park@gmail.com>
To:     "Shah, Amit" <aams@amazon.de>
Cc:     "sj38.park@gmail.com" <sj38.park@gmail.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "rientjes@google.com" <rientjes@google.com>,
        "acme@kernel.org" <acme@kernel.org>,
        "snu@amazon.de" <snu@amazon.de>,
        "peterz@infradead.org" <peterz@infradead.org>,
        "minchan@kernel.org" <minchan@kernel.org>,
        "vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>,
        "linux-damon@amazon.com" <linux-damon@amazon.com>,
        "zgf574564920@gmail.com" <zgf574564920@gmail.com>,
        "vbabka@suse.cz" <vbabka@suse.cz>,
        "fan.du@intel.com" <fan.du@intel.com>,
        "Park, Seongjae" <sjpark@amazon.de>,
        "amit@kernel.org" <amit@kernel.org>,
        "gthelen@google.com" <gthelen@google.com>,
        "shuah@kernel.org" <shuah@kernel.org>,
        "Foerster, Leonard" <foersleo@amazon.de>,
        "guoju.fgj@alibaba-inc.com" <guoju.fgj@alibaba-inc.com>,
        "benh@kernel.crashing.org" <benh@kernel.crashing.org>,
        "shakeelb@google.com" <shakeelb@google.com>,
        "Woodhouse, David" <dwmw@amazon.co.uk>,
        "greg@kroah.com" <greg@kroah.com>,
        "alexander.shishkin@linux.intel.com" 
        <alexander.shishkin@linux.intel.com>,
        "rppt@kernel.org" <rppt@kernel.org>,
        "mgorman@suse.de" <mgorman@suse.de>,
        "Jonathan.Cameron@Huawei.com" <Jonathan.Cameron@Huawei.com>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "brendanhiggins@google.com" <brendanhiggins@google.com>,
        "corbet@lwn.net" <corbet@lwn.net>,
        "namhyung@kernel.org" <namhyung@kernel.org>,
        "rostedt@goodmis.org" <rostedt@goodmis.org>,
        "elver@google.com" <elver@google.com>,
        "riel@surriel.com" <riel@surriel.com>, linux-doc@vger.kernel.org,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v29 04/13] mm/idle_page_tracking: Make PG_idle reusable
Date:   Fri, 11 Jun 2021 13:49:20 +0000
Message-Id: <20210611134920.6302-1-sjpark@amazon.de>
In-Reply-To: <ac98333d677a3ae8d25a998816e025954826e5c1.camel@amazon.com>
Precedence: bulk

From: SeongJae Park <sjpark@amazon.de>

Hi Amit,

On Fri, 11 Jun 2021 12:55:27 +0000 "Shah, Amit" <aams@amazon.de> wrote:

> On Thu, 2021-05-20 at 07:56 +0000, SeongJae Park wrote:
> > From: SeongJae Park <sjpark@amazon.de>
> > 
> > PG_idle and PG_young allow the two PTE Accessed bit users, Idle Page
> > Tracking and the reclaim logic concurrently work while don't interfere
> 
> ... while not interfering with ...

Will fix so.

> 
> > each other.  That is, when they need to clear the Accessed bit, they set
> > PG_young to represent the previous state of the bit, respectively.  And
> > when they need to read the bit, if the bit is cleared, they further read
> > the PG_young to know whether the other has cleared the bit meanwhile or
> > not.
> > 
> > We could add another page flag and extend the mechanism to use the flag
> > if we need to add another concurrent PTE Accessed bit user subsystem.
> > However, the space is limited.  Meanwhile, if the new subsystem is
> > mutually exclusive with IDLE_PAGE_TRACKING or interfering with it is not
> > a real problem, it would be ok to simply reuse the PG_idle flag.
> > However, it's impossible because the flags are dependent on
> > IDLE_PAGE_TRACKING.
> 
> For better readability, I suggest:
> 
> For yet another user of the PTE Accessed bit, we could add another page
> flag, or extend the mechanism to use the flags. For the DAMON usecase,
> however, we don't need to do that just yet.  IDLE_PAGE_TRACKING and
> DAMON are mutually exclusive, so there's only ever going to be one user
> of the current set of flags. 
> 
> In this commit, we split out the CONFIG options to allow for the use of
> PG_young and PG_idle outside of idle page tracking.

Thank you for the suggestion, it looks better to me, either.  I will update so
in the next spin.


Thanks,
SeongJae Park

[...]