Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210611014755.124483-1-breno.lima@nxp.com> <VI1PR04MB59358BDBE0A6FA8A8966C66789349@VI1PR04MB5935.eurprd04.prod.outlook.com>
In-Reply-To: <VI1PR04MB59358BDBE0A6FA8A8966C66789349@VI1PR04MB5935.eurprd04.prod.outlook.com>
From:   Breno Matheus Lima <brenomatheus@gmail.com>
Date:   Fri, 11 Jun 2021 10:57:59 -0400
Message-ID: <CAC4tdFUBGUiX4ydq4VeJcEXqmx6f2fvu4cq1ETw5mtueADz6yw@mail.gmail.com>
Subject: Re: [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP detection
To:     Jun Li <jun.li@nxp.com>
Cc:     Breno Matheus Lima <breno.lima@nxp.com>,
        "peter.chen@kernel.org" <peter.chen@kernel.org>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Jun,

Em sex., 11 de jun. de 2021 =C3=A0s 02:24, Jun Li <jun.li@nxp.com> escreveu=
:
>
>
> > -----Original Message-----
> > From: Breno Matheus Lima <breno.lima@nxp.com>
> > Sent: Friday, June 11, 2021 9:48 AM
> > To: peter.chen@kernel.org
> > Cc: gregkh@linuxfoundation.org; shawnguo@kernel.org;
> > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> > dl-linux-imx <linux-imx@nxp.com>; linux-usb@vger.kernel.org;
> > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> > brenomatheus@gmail.com; Jun Li <jun.li@nxp.com>; Breno Matheus Lima
> > <breno.lima@nxp.com>
> > Subject: [PATCH] mx8mm: usb: chipidea: Fix Battery Charger 1.2 CDP dete=
ction
> >
> > i.MX8MM cannot detect certain CDP USB HUBs. usbmisc_imx.c driver is not
> > following CDP timing requirements defined by USB BC 1.2 specification a=
nd
> > section 3.2.4 Detection Timing CDP.
> >
> > During Primary Detection the i.MX device should turn on VDP_SRC and IDM=
_SINK
> > for a minimum of 40ms (TVDPSRC_ON). After a time of TVDPSRC_ON, the PD =
is
> > allowed to check the status of the D- line. Current implementation is w=
aiting
> > between 1ms and 2ms, and certain BC 1.2 complaint USB HUBs cannot be de=
tected.
> > Increase delay to 40ms allowing enough time for primary detection.
> >
> > During secondary detection the PD is required to disable VDP_SRC and ID=
M_SNK,
> > and enable VDM_SRC and IDP_SINK for at least 40ms (TVDMSRC_ON).
> >
> > Current implementation is not disabling VDP_SRC and IDM_SNK, introduce
> > disable sequence in imx7d_charger_secondary_detection() function.
> >
> > VDM_SRC and IDP_SINK should be enabled for at least 40ms (TVDMSRC_ON).
> > Increase delay allowing enough time for detection.
> >
>
> Fixes: 746f316b753a ("usb: chipidea: introduce imx7d USB charger detectio=
n")
>

Thanks for pointing this out, I have just sent another version.

Best regards,
Breno Lima