Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752906AbWKGPLZ (ORCPT ); Tue, 7 Nov 2006 10:11:25 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753961AbWKGPLZ (ORCPT ); Tue, 7 Nov 2006 10:11:25 -0500 Received: from excu-mxob-1.symantec.com ([198.6.49.12]:26294 "EHLO excu-mxob-1.symantec.com") by vger.kernel.org with ESMTP id S1752906AbWKGPLY (ORCPT ); Tue, 7 Nov 2006 10:11:24 -0500 Date: Tue, 7 Nov 2006 15:11:29 +0000 (GMT) From: Hugh Dickins X-X-Sender: hugh@blonde.wat.veritas.com To: Paulo Marques cc: Rik Bobbaers , linux-kernel@vger.kernel.org, linux-mm@vger.kernel.org Subject: Re: very small code cleanup In-Reply-To: <45509B97.2080104@grupopie.com> Message-ID: References: <4550986C.8020802@cc.kuleuven.be> <45509B97.2080104@grupopie.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 07 Nov 2006 15:11:11.0868 (UTC) FILETIME=[F5F0C3C0:01C7027E] Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 27 On Tue, 7 Nov 2006, Paulo Marques wrote: > Rik Bobbaers wrote: > > > > in mm/mlock.c , mm is defined as vma->vm_mm, why not use that one for the > > decrement of pages? > > Because vma can change here: > > if (*prev) { > vma = *prev; > goto success; > } That's a good piece of cautious observation ... > > and then mm won't be the same as vma->vm_mm.. ... but it would be a bug if *prev's vm_mm were different from mm and from the original vma->vm_mm: Rik's patch looks sensible to me. Hugh - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/