Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Fri, 11 Jun 2021 13:48:54 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Tony Krowiak <akrowiak@linux.ibm.com>
Cc:     linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        borntraeger@de.ibm.com, cohuck@redhat.com,
        pasic@linux.vnet.ibm.com, jjherne@linux.ibm.com,
        alex.williamson@redhat.com, kwankhede@nvidia.com,
        frankja@linux.ibm.com, david@redhat.com, imbrenda@linux.ibm.com,
        hca@linux.ibm.com
Subject: Re: [PATCH 1/3] s390/vfio-ap: clean up mdev resources when remove
 callback invoked
Message-ID: <20210611164854.GT1002214@nvidia.com>
References: <20210609224634.575156-1-akrowiak@linux.ibm.com>
 <20210609224634.575156-2-akrowiak@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210609224634.575156-2-akrowiak@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from mlx.ziepe.ca (47.55.113.94) by MN2PR20CA0010.namprd20.prod.outlook.com (2603:10b6:208:e8::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.20 via Frontend Transport; Fri, 11 Jun 2021 16:48:55 +0000
Received: from jgg by mlx with local (Exim 4.94)        (envelope-from <jgg@nvidia.com>)        id 1lrkL0-005gha-QH; Fri, 11 Jun 2021 13:48:54 -0300
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: d6bc47ad-f664-4dd5-d16d-08d92cf8cd64
X-MS-TrafficTypeDiagnostic: BL0PR12MB5554:
X-MS-Exchange-Transport-Forked: True
X-Microsoft-Antispam-PRVS: <BL0PR12MB555419D5755D1103EC08096DC2349@BL0PR12MB5554.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:8882;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mdb2NidruRQ1/Vul2rr7vC405Sd520/hOIqXIxWRxfOpI+RBCR0mtNU7ojcCnnMiMon4/3riKHDLEbDbqHAWYsEuB1IZ7bXNuLF7zpTBm5Jjl6+5PkfcnaMVGNvd31RMnwfZhrUK+tZrq5p+Ntdy0xf957FgkigRXhaP0hfDiOD7TkynxcoSVnK3NLVUurNFXdXGchKK2+P4bxb2Zyx07fKFhHuIldfqzVBFt1Dj30MQGyvYuK6HNAqaTSOHRc2C4qHrl+6RZbkm7zN10Yi8h+7Q+LNTZpA0XZ4rQ+diFXvQsakABh2W1VYpXM3jbmYpjeKgfFnnutg+zQRw34tQBwY5KePl/SOx5S4tR1WiprXhvWf7HzD6kyxjzXM5tc/NeiGadCxqfNFC7zSQ9Mkf1OC17dQDYi4lZog2AEk1lpgu5y94qgcG+gTn12wSmMBCd2wdc4trwXrkwa5Ag/ybSlR/OSmzT3p9Opx6Uweh8ocFZDmvZ8E+qPBmNdOLTzOJeZ72Eto8WDqU/XpU5pRFSQPZFjYdW7ZE45ggpjzqOtqTkgx9HT/ESvkMNoSrJe/+k8t6VDRiVHZmgzwDMxkdwJ71u32fE56zaKKXh2C2G3Q=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL0PR12MB5506.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(396003)(136003)(366004)(39860400002)(376002)(66476007)(66556008)(66946007)(86362001)(478600001)(33656002)(8676002)(1076003)(426003)(9746002)(5660300002)(2906002)(9786002)(2616005)(7416002)(316002)(36756003)(38100700002)(6916009)(8936002)(26005)(83380400001)(4326008)(186003);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CfM1BXujFK5VrC3hl2koOFQArHKsjfR8/kbvryvwIz2bHppJlwpDGc4Y383N?=
 =?us-ascii?Q?ZGIhoygrPHDwEgmS6SHOBxKu2QXX5xoLJDATvR5QXBLUE6FmsiXioqIPW7nS?=
 =?us-ascii?Q?bIhHRAOKIi6T3ccV3wbZhLHSGypIuJJfkDn5YN/yVj0vEcOAE6vXGf1BPChK?=
 =?us-ascii?Q?VFat4NOKwOvqecCQCWY94xGiqiV+xQy7wKRgFHMxQU6qC7L1U3AQCoziOhKk?=
 =?us-ascii?Q?NqD9ByRXKYPDrMgvtOFrEdqGyelHx22prVlOn10b++IY1L7N6QNvHkPZ7XWq?=
 =?us-ascii?Q?HhJyknLZu345n0TExLCNMB310mVF1zylhtCWWR8BFLu7/+ayFYelpRHOY+Ii?=
 =?us-ascii?Q?jrjzAtREStlhX+Rvh1hpxM4wRqmDTBtdZ3CjMOF8KjmBxS+BAyxFoQrgwm5Q?=
 =?us-ascii?Q?5pAdEauZpg0+UNbYoRr6nziXFAxyvFdin5gfloSLFTDuWMwUiMT7ygR5fM2d?=
 =?us-ascii?Q?ThxDSp7XARVo6n6cFRF0GFGKo8T2Q8FxmWB354xGqsAGXjHAx8umRQ2+AeAK?=
 =?us-ascii?Q?g7NMpA9aegIUlejMDydHgHf2CDlstfwYH/hXhOw3PweHDCkmJcGOG/Nsmb+h?=
 =?us-ascii?Q?K5wCQns53x7xIS1DAQa/qkco1liuZI2ptkthokVheTIpboDG14Ww3ZT67DDa?=
 =?us-ascii?Q?1fVdeS3zZz6FhGzo5fSjpgaMCF6Dgk754QB+jt9mSj/tmvgkPfjiqj2RpAwW?=
 =?us-ascii?Q?emKJLg3s1YcWt4nPzaSCt+6ijRGJUI4HU1dve5kvCT/OzJUIr9RkDFt4Rc1x?=
 =?us-ascii?Q?MWD5N/C9IKGSN2VBe9PuBKQcoQ0xdtPUs2xGHiHqnomvvviMUXE4t1Imj6FQ?=
 =?us-ascii?Q?2sqBHxXp7OpzpkqHjZnZirk21eSImv+gqiSpHY20GKUtOWcduTRdKBQ5eHbM?=
 =?us-ascii?Q?C3oPlRECQXRUpbKLoy/IrOFgr61rL+HNcIaF0dBhjdXnNgJnLlljEKkKCM6t?=
 =?us-ascii?Q?SyKwmLEzENyE29T5GH7ioJuSFergx3007ybqu+OxNj6bezNt6tCOMyQDIWgV?=
 =?us-ascii?Q?WSNDnibrALVjSV9Kd6QmQPeNoQwHg0YfrpQzETj0yZw0oBosXHaHSkpTji10?=
 =?us-ascii?Q?/P9LU0vtEW07BW71l9OuCwJXgpZJ6p1c8YvHlX856OhD4IWoeuxEnNHxwUnf?=
 =?us-ascii?Q?UP+x5OXjEavzfAUjt/mRaUZNre6F6uzZzqGe08N1ag5Cj5fkI3eyXU/U31xi?=
 =?us-ascii?Q?7Tc3Ro/oHkDYSFATdIcGf7xVz6ePcjIUpB1hFVCwBcAPwGqK057lI2uyoepq?=
 =?us-ascii?Q?bseA7Bm0svvH1TZehKz6pCYJQsiwxDlFGdwA0h+uaraqlDI4GAZBcP8MhpA3?=
 =?us-ascii?Q?dc+rkN91gIVga9glmTG/JWp3?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6bc47ad-f664-4dd5-d16d-08d92cf8cd64
X-MS-Exchange-CrossTenant-AuthSource: BL0PR12MB5506.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jun 2021 16:48:56.0308
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uSMjBUlLPsv0Rnw1Na+jfwbd4swLcsAtZz33C9u8wGDVZENhzt3nVgCZvSfm7kE7
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5554
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 09, 2021 at 06:46:32PM -0400, Tony Krowiak wrote:
> The mdev remove callback for the vfio_ap device driver bails out with
> -EBUSY if the mdev is in use by a KVM guest (i.e., the KVM pointer in the
> struct ap_matrix_mdev is not NULL). The intended purpose was
> to prevent the mdev from being removed while in use. There are two
> problems with this scenario:
> 
> 1. Returning a non-zero return code from the remove callback does not
>    prevent the removal of the mdev.
> 
> 2. The KVM pointer in the struct ap_matrix_mdev will always be NULL because
>    the remove callback will not get invoked until the mdev fd is closed.
>    When the mdev fd is closed, the mdev release callback is invoked and
>    clears the KVM pointer from the struct ap_matrix_mdev.
> 
> Let's go ahead and remove the check for KVM in the remove callback and
> allow the cleanup of mdev resources to proceed.
> 
> Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
> ---
>  drivers/s390/crypto/vfio_ap_ops.c | 10 ----------
>  1 file changed, 10 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason