Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     <sj38.park@gmail.com>
CC:     <Jonathan.Cameron@Huawei.com>, <acme@kernel.org>,
        <akpm@linux-foundation.org>, <alexander.shishkin@linux.intel.com>,
        <amit@kernel.org>, <benh@kernel.crashing.org>,
        <brendanhiggins@google.com>, <corbet@lwn.net>, <david@redhat.com>,
        <dwmw@amazon.com>, <elver@google.com>, <fan.du@intel.com>,
        <foersleo@amazon.de>, <greg@kroah.com>, <gthelen@google.com>,
        <guoju.fgj@alibaba-inc.com>, <linux-damon@amazon.com>,
        <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-mm@kvack.org>, <mgorman@suse.de>, <minchan@kernel.org>,
        <mingo@redhat.com>, <namhyung@kernel.org>, <peterz@infradead.org>,
        <riel@surriel.com>, <rientjes@google.com>, <rostedt@goodmis.org>,
        <rppt@kernel.org>, <shakeelb@google.com>, <shuah@kernel.org>,
        <sjpark@amazon.de>, <snu@amazon.de>, <vbabka@suse.cz>,
        <vdavydov.dev@gmail.com>, <zgf574564920@gmail.com>
References: <20210520075629.4332-8-sj38.park@gmail.com>
Subject: Re: [PATCH v29 07/13] mm/damon: Implement a debugfs-based user space
 interface
From:   <sieberf@amazon.com>
Message-ID: <e8687948-649f-348f-e4d6-2175b1c47551@amazon.com>
Date:   Fri, 11 Jun 2021 20:59:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210520075629.4332-8-sj38.park@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Precedence: bulk

+ Returns non-empty string on success, negarive error code otherwise.

Nit: typo, 'negarive'


+    if (ctx->kdamond) {
+        if (targetid_is_pid(ctx))
+            dbgfs_put_pids(targets, nr_targets);
+        ret = -EBUSY;
+        goto unlock_out;

I don't understand this block, what does EBUSY mean in this context?

+    if (sscanf(kbuf, "%s", kbuf) != 1) {
+        kfree(kbuf);
+        return -EINVAL;
+    }

Nit, this diverts from other patterns use elsewhere where error 
conditions that need to free memory use a goto label.