Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp871156pxj; Fri, 11 Jun 2021 13:54:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwB9WL69NtGLHmIKR+AT2Bz8It9Diu6+ogdFzkbHdr1z5FHMysRSVGVrMaZcwaUrEijqsE6 X-Received: by 2002:aa7:d610:: with SMTP id c16mr5565273edr.207.1623444853501; Fri, 11 Jun 2021 13:54:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623444853; cv=none; d=google.com; s=arc-20160816; b=wt+5x6DPoMr9eyhBG0CpQ6MaHj50VpTdi/CSF8a6XgRvcK7lLWBVAk4amN9WoSxzA7 V+NWubkVuYInHTfoeidHMiGni4XLRKoNfaGyHhYgPqU61K08IWAu2V4rRhUxo+ecT7Rs /snfvbPJEZhEiXmoRuIgAhbTDMgXZnC5vwCCl1LcQgPUBnRl/UG7IH18023JSHHhI6Dl mRDU4C1EFe5b0lDPpVTLg0bwv1SKbNkPiakhym/7EjYqeI+qslD2N7JiFBy51kRNWvzZ qFhcUvD1p6XlWFq6Zxsx02hbuCoGAHnwpTaxrv5/rGGpmGhWkP15NrVbMphnrAtH52d5 XJoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=J0KQ333VmXMh9WkmLlAfo8ONJKiYjxWClfdlf5KolZ0=; b=dosoC4bckHyT0/EMjZ0X50HTEq94nF2TvbBaY8L5QwxifNdIDwrDWKNr00L7SD2Kqy OZEdxxDsfTkx1hVsyTZJ3Y2FMNlb4Bku7yt0CzVLOtnq5Ow2tpoXYkFxR+Bn+6rUAYpE JJ/VIV8vS7c9IyJn9KEIU2/1+vB9TKH83StYawhAlBh3tQBoKbEqvGxjI3cmGAt9jdom HDHz/AyWl8Eqzmk/X1YzdfhBXQnYvgMThDztXRi4+YYX4WELIxjeUtCJBY1OHAIK+Vyq bbFzs0bq5BUhHp3TyAqKpPJiiAK9ghJxyNbN1SlT01EUJbaSwRINy/bO3V+cZzSNB4DH AznQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=S1H5+K1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id pg13si5150165ejb.35.2021.06.11.13.53.50; Fri, 11 Jun 2021 13:54:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=S1H5+K1O; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbhFKUxq (ORCPT + 99 others); Fri, 11 Jun 2021 16:53:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230382AbhFKUxp (ORCPT ); Fri, 11 Jun 2021 16:53:45 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 36E28C0617AF; Fri, 11 Jun 2021 13:51:33 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id n17so11368464ljg.2; Fri, 11 Jun 2021 13:51:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J0KQ333VmXMh9WkmLlAfo8ONJKiYjxWClfdlf5KolZ0=; b=S1H5+K1OuSLbpurapwR3Cmk/hPmg99rWIdp6GG32kCGnIKiUVuXwn0S1Kn3eF+GWuI fLw7pbo8uDy/HI8cg+WvLWgUA7FqmUQy15ni2s5U1wpSGgimLUfPKInedWiRzr39Tuqq JxTnSkhEDFyABfD6cmMm0CHJwiJxtRsw6q4dLWWW0QtyXoT7IA2mY+IE4D79qh6UfcO4 Rws71hWYjvriZviShx+hIvHehPwsNlngAIk6ljk0nk60lceaXZ05CwKanGJn4qtWMS40 hWeYpIkOUN+Lyb1XUbmtt2H2X9l9mrMSV3F25D2AzYk01XrreGePDpcCDcEyxA7Yi4Vn moYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J0KQ333VmXMh9WkmLlAfo8ONJKiYjxWClfdlf5KolZ0=; b=rT+KfStl6t5XQbTTbd3qnaRcMqQLcXL26vPMR5SV9dLohrJxD55q6njaETMpt7c0BL NMLRGKHiscYTzK2NM95H+gipih2s1A2O6xPlxytfUctGxywhDhcFZLylrytn+IEfFl7/ ZaE/TlaiM2I/l90/DUy+AjDYFaij2BdOCHCYnrbq2nrgQMP/R85SWtC3EDlFrhAuw4Mq lV3MYGlTYwoR8Bo0/Nqm5hZLShLTuQFtyFtuZdtAp9+8ZfIDGxH5JPxWZ5v7E06FNLr7 OlCuUPuzb2BWQQF16stB4fQpAx3ZwNFBJSNCXUt/F3kscvdAuOmeVuPvrcGMv6hg7g0T kmPQ== X-Gm-Message-State: AOAM533jIsAvjN5GDKu4cveVzXFQPxTAUcFMtEsuSkOZ+pwxgusSTuLs u0+SmqOmCi7xxh5N41U7Tqg= X-Received: by 2002:a2e:8816:: with SMTP id x22mr4507760ljh.181.1623444691562; Fri, 11 Jun 2021 13:51:31 -0700 (PDT) Received: from localhost.localdomain (h-98-128-228-193.NA.cust.bahnhof.se. [98.128.228.193]) by smtp.gmail.com with ESMTPSA id r7sm687118lfr.242.2021.06.11.13.51.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Jun 2021 13:51:31 -0700 (PDT) From: Rikard Falkeborn To: Peter Zijlstra Cc: Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Thomas Gleixner , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Kan Liang , Alexander Antonov , Rikard Falkeborn Subject: [PATCH V2 3/4] perf/x86/intel/uncore: Constify freerunning_counters Date: Fri, 11 Jun 2021 22:51:11 +0200 Message-Id: <20210611205112.27225-4-rikard.falkeborn@gmail.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210611205112.27225-1-rikard.falkeborn@gmail.com> References: <20210611205112.27225-1-rikard.falkeborn@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These are never modified, so make them const to allow the compiler to put them in read-only memory. Signed-off-by: Rikard Falkeborn --- Changes since v1: - None arch/x86/events/intel/uncore.h | 4 ++-- arch/x86/events/intel/uncore_snb.c | 6 +++--- arch/x86/events/intel/uncore_snbep.c | 14 +++++++------- 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/x86/events/intel/uncore.h b/arch/x86/events/intel/uncore.h index 83b25a7b8c27..6a7f0104bb38 100644 --- a/arch/x86/events/intel/uncore.h +++ b/arch/x86/events/intel/uncore.h @@ -79,7 +79,7 @@ struct intel_uncore_type { struct intel_uncore_pmu *pmus; const struct intel_uncore_ops *ops; struct uncore_event_desc *event_descs; - struct freerunning_counters *freerunning; + const struct freerunning_counters *freerunning; const struct attribute_group *attr_groups[4]; const struct attribute_group **attr_update; struct pmu *pmu; /* for custom pmu ops */ @@ -175,7 +175,7 @@ struct freerunning_counters { unsigned int box_offset; unsigned int num_counters; unsigned int bits; - unsigned *box_offsets; + const unsigned *box_offsets; }; struct intel_uncore_topology { diff --git a/arch/x86/events/intel/uncore_snb.c b/arch/x86/events/intel/uncore_snb.c index e30b69fba939..d9542943cdbe 100644 --- a/arch/x86/events/intel/uncore_snb.c +++ b/arch/x86/events/intel/uncore_snb.c @@ -611,7 +611,7 @@ enum perf_snb_uncore_imc_freerunning_types { SNB_PCI_UNCORE_IMC_FREERUNNING_TYPE_MAX, }; -static struct freerunning_counters snb_uncore_imc_freerunning[] = { +static const struct freerunning_counters snb_uncore_imc_freerunning[] = { [SNB_PCI_UNCORE_IMC_DATA_READS] = { SNB_UNCORE_PCI_IMC_DATA_READS_BASE, 0x0, 0x0, 1, 32 }, [SNB_PCI_UNCORE_IMC_DATA_WRITES] = { SNB_UNCORE_PCI_IMC_DATA_WRITES_BASE, @@ -1352,13 +1352,13 @@ enum perf_tgl_uncore_imc_freerunning_types { TGL_MMIO_UNCORE_IMC_FREERUNNING_TYPE_MAX }; -static struct freerunning_counters tgl_l_uncore_imc_freerunning[] = { +static const struct freerunning_counters tgl_l_uncore_imc_freerunning[] = { [TGL_MMIO_UNCORE_IMC_DATA_TOTAL] = { 0x5040, 0x0, 0x0, 1, 64 }, [TGL_MMIO_UNCORE_IMC_DATA_READ] = { 0x5058, 0x0, 0x0, 1, 64 }, [TGL_MMIO_UNCORE_IMC_DATA_WRITE] = { 0x50A0, 0x0, 0x0, 1, 64 }, }; -static struct freerunning_counters tgl_uncore_imc_freerunning[] = { +static const struct freerunning_counters tgl_uncore_imc_freerunning[] = { [TGL_MMIO_UNCORE_IMC_DATA_TOTAL] = { 0xd840, 0x0, 0x0, 1, 64 }, [TGL_MMIO_UNCORE_IMC_DATA_READ] = { 0xd858, 0x0, 0x0, 1, 64 }, [TGL_MMIO_UNCORE_IMC_DATA_WRITE] = { 0xd8A0, 0x0, 0x0, 1, 64 }, diff --git a/arch/x86/events/intel/uncore_snbep.c b/arch/x86/events/intel/uncore_snbep.c index b5b22fe473d8..507bb83e1463 100644 --- a/arch/x86/events/intel/uncore_snbep.c +++ b/arch/x86/events/intel/uncore_snbep.c @@ -3885,7 +3885,7 @@ enum perf_uncore_iio_freerunning_type_id { }; -static struct freerunning_counters skx_iio_freerunning[] = { +static const struct freerunning_counters skx_iio_freerunning[] = { [SKX_IIO_MSR_IOCLK] = { 0xa45, 0x1, 0x20, 1, 36 }, [SKX_IIO_MSR_BW] = { 0xb00, 0x1, 0x10, 8, 36 }, [SKX_IIO_MSR_UTIL] = { 0xb08, 0x1, 0x10, 8, 36 }, @@ -4588,7 +4588,7 @@ enum perf_uncore_snr_iio_freerunning_type_id { SNR_IIO_FREERUNNING_TYPE_MAX, }; -static struct freerunning_counters snr_iio_freerunning[] = { +static const struct freerunning_counters snr_iio_freerunning[] = { [SNR_IIO_MSR_IOCLK] = { 0x1eac, 0x1, 0x10, 1, 48 }, [SNR_IIO_MSR_BW_IN] = { 0x1f00, 0x1, 0x10, 8, 48 }, }; @@ -4931,7 +4931,7 @@ enum perf_uncore_snr_imc_freerunning_type_id { SNR_IMC_FREERUNNING_TYPE_MAX, }; -static struct freerunning_counters snr_imc_freerunning[] = { +static const struct freerunning_counters snr_imc_freerunning[] = { [SNR_IMC_DCLK] = { 0x22b0, 0x0, 0, 1, 48 }, [SNR_IMC_DDR] = { 0x2290, 0x8, 0, 2, 48 }, }; @@ -5153,15 +5153,15 @@ enum perf_uncore_icx_iio_freerunning_type_id { ICX_IIO_FREERUNNING_TYPE_MAX, }; -static unsigned icx_iio_clk_freerunning_box_offsets[] = { +static const unsigned icx_iio_clk_freerunning_box_offsets[] = { 0x0, 0x20, 0x40, 0x90, 0xb0, 0xd0, }; -static unsigned icx_iio_bw_freerunning_box_offsets[] = { +static const unsigned icx_iio_bw_freerunning_box_offsets[] = { 0x0, 0x10, 0x20, 0x90, 0xa0, 0xb0, }; -static struct freerunning_counters icx_iio_freerunning[] = { +static const struct freerunning_counters icx_iio_freerunning[] = { [ICX_IIO_MSR_IOCLK] = { 0xa55, 0x1, 0x20, 1, 48, icx_iio_clk_freerunning_box_offsets }, [ICX_IIO_MSR_BW_IN] = { 0xaa0, 0x1, 0x10, 8, 48, icx_iio_bw_freerunning_box_offsets }, }; @@ -5443,7 +5443,7 @@ enum perf_uncore_icx_imc_freerunning_type_id { ICX_IMC_FREERUNNING_TYPE_MAX, }; -static struct freerunning_counters icx_imc_freerunning[] = { +static const struct freerunning_counters icx_imc_freerunning[] = { [ICX_IMC_DCLK] = { 0x22b0, 0x0, 0, 1, 48 }, [ICX_IMC_DDR] = { 0x2290, 0x8, 0, 2, 48 }, [ICX_IMC_DDRT] = { 0x22a0, 0x8, 0, 2, 48 }, -- 2.32.0