Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp985252pxj; Fri, 11 Jun 2021 17:40:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxpu0oMytmZqkj4ILGyHtWx5G6XOfCVW1DGoXLtfzLJoWN5AQy22AAIfoof7eB0F7BL0Als X-Received: by 2002:a05:6402:1652:: with SMTP id s18mr6035005edx.131.1623458418585; Fri, 11 Jun 2021 17:40:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623458418; cv=none; d=google.com; s=arc-20160816; b=n2wCEhQADj9Mp1xBNOfjv8eUAkGGBOS7pGl+8aZLmCoO+hO2BRyz1eH5yHTJGWcb0Q mkdQvdQVrCE3X/OLoKcHvHkjlcNBp6kuLhehJyG2qXdMJZrj8Sw5BNsFMpZ3zHfJWt1G TslGlkLJVZ0ertYb9Xrk6xsxbBxZkbDDUDFYrS/jqRkmxztUwlGKXlZbab4zGhW/9+XR 8k0nvOh1W6kWCVJ/UMAkNtPMlNkCN6BvuFdUPkI3QZHWWo2skh7WqmMkFalFO8soD0E+ 2VOnaDppFGF91V8oJVdTHr04a5yvFSvI2685Ln9LcMHaDsKZ8ylZPf8/7HvGSUnZnYTo p2SQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=sqgAgi6DWa3DKRP6Z1AiluQZf1K0RUVDya9Ec1d+PQE=; b=Wg964jZvd79UmlfiDO4MHZP1f6eKrcqdUB/SHAKaFsWkj1U0JCnpE9IWY+cA1FR7w6 nodQBIjBmvCO3re17XzTClWkKdfta3gNUiCpmcyeacx9f4pFRnAYivHmHnH+y4bPhT6J NE/tlsT4P4GCT58v8EcSPfJ09DnEF2ph3NgxEasOs9ICI0ygIyZPiiwNEp8jdzZaxh3Z BV8DjQTdTRmjcQERGiIbQJAof2ki+9Th1oqOHauRs//62TaDVebTPORMfZuvAUFHaaFD 6RNkzw3K2a0JvFsV7qASLRzx/MnP6FCOTd43QszzyS4CHHbaMCJf6dsJ+h+vaWSbeR8Q SmtQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p23si6580265edw.135.2021.06.11.17.39.56; Fri, 11 Jun 2021 17:40:18 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230301AbhFLAgm (ORCPT + 99 others); Fri, 11 Jun 2021 20:36:42 -0400 Received: from mga06.intel.com ([134.134.136.31]:11529 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbhFLAgl (ORCPT ); Fri, 11 Jun 2021 20:36:41 -0400 IronPort-SDR: Aia5AvZpTkz+8wpFZEiDEAiWFP+UMq1+mdULKi/7j9NGyqM0/h5LnlCBCiCDHk6e+jtH4wCH3e cou+8O35rJlg== X-IronPort-AV: E=McAfee;i="6200,9189,10012"; a="266783225" X-IronPort-AV: E=Sophos;i="5.83,267,1616482800"; d="scan'208";a="266783225" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 17:34:41 -0700 IronPort-SDR: 1J4nclyDz9Ncrq4EjuDR2bN8196DUcFI3KZYaQyYWjQQxCaOAd3V2IWo0GlbXIvn8c8t14PRoM 3cRi40NLAJBQ== X-IronPort-AV: E=Sophos;i="5.83,267,1616482800"; d="scan'208";a="486782447" Received: from svkandu1-mobl1.amr.corp.intel.com (HELO [10.251.4.209]) ([10.251.4.209]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 17:34:40 -0700 Subject: Re: [PATCH v8 3/5] selftests/sgx: Dump enclave memory map To: Shuah Khan , Jarkko Sakkinen , shuah@kernel.org Cc: linux-kselftest@vger.kernel.org, linux-sgx@vger.kernel.org, Reinette Chatre , Dave Hansen , linux-kernel@vger.kernel.org References: <20210610083021.392269-1-jarkko@kernel.org> <20210610083021.392269-3-jarkko@kernel.org> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: Date: Fri, 11 Jun 2021 17:34:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/11/21 3:45 PM, Shuah Khan wrote: >> >>   @@ -167,6 +169,18 @@ FIXTURE_SETUP(enclave) >>       memset(&self->run, 0, sizeof(self->run)); >>       self->run.tcs = self->encl.encl_base; >>   +    maps_file = fopen("/proc/self/maps", "r"); > > I almost applied these. Does this require root access, if so, > please add logic to skip the test if non-root user runs it. > > Same comments for all other paths that might require root access. This specifically doesn't require root. Anything can read its own /proc/self/maps file.