Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 12 Jun 2021 15:04:17 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     robh+dt@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de,
        festevam@gmail.com, linux-imx@nxp.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sl: add PXP module
Message-ID: <20210612070416.GV29138@dragon>
References: <20210527210742.2609-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210527210742.2609-1-andreas@kemnade.info>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Thu, May 27, 2021 at 11:07:42PM +0200, Andreas Kemnade wrote:
> While the EPDC is optional, all editions have the PXP module, so adding
> it to the corresponding .dtsi
> Information taken from freescale kernel, compared with the
> reference manual and tested by a separate program.
> 
> Since it does not depend on external wiring, the
> status = "disabled" is left out here.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/imx6sl.dtsi | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
> index 997b96c1c47b..6be83e863f19 100644
> --- a/arch/arm/boot/dts/imx6sl.dtsi
> +++ b/arch/arm/boot/dts/imx6sl.dtsi
> @@ -762,8 +762,11 @@
>  			};
>  
>  			pxp: pxp@20f0000 {
> +				compatible = "fsl,imx6sl-pxp", "fsl,imx6ull-pxp";

"fsl,imx6sl-pxp" needs to be documented.

Shawn

>  				reg = <0x020f0000 0x4000>;
>  				interrupts = <0 98 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX6SL_CLK_PXP_AXI>;
> +				clock-names = "axi";
>  			};
>  
>  			epdc: epdc@20f4000 {
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel