Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1175599pxj; Sat, 12 Jun 2021 00:19:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzVJ54JaxJSKt3hHyxfO8/5lEM7ipfGG/7FUQiqDdlXF8NweHnls7XxY0S/9B70oaEVO0K/ X-Received: by 2002:a05:6402:711:: with SMTP id w17mr7588668edx.90.1623482396910; Sat, 12 Jun 2021 00:19:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623482396; cv=none; d=google.com; s=arc-20160816; b=cYuoyCRD8znT0AxOqKaRpIOdty/NRB7h1Ft5RYneMuMgN+KRTyJB4xe51wiiKKIx1T eXM11wZI5dXfQcxfDbloNCNr6m3D6Wi3tRxoL91IQqz03WgcP+MxpHvfsDexk0qrza4R mopos9ggHwLGRzckRS4CicpTjHEKuLz1rGzn6lCjcWUlEFHSkiFWIraM3UXjYVfqwdMW Yn+hEDMKUrpjmOHD7fTOeO8+Uzovx16GFjqnTKUZg0tLrSNyJJvKaU4pud5sZhjRD+H5 SD73+2HhwpdGZMGDJKfuNvXqaVd1+5ZSflsOoHXZ1D95LGeN+FVpiAGk4Cgmb10kdhhL BWBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=Hpjk2O5a9FW144DkbZmLl0i9YUaNRWqhcHw4RijOCxk=; b=P3z0jhcDM01MTXnbo7Xd74tR0lLe5Bg3uG/jzef3Q/kinPacqoZNbR9ior+tllwIBb L4J8iZTHkZFEgq9GZ1FU/wl3ZheePmWxwAbChsxb1DRyzvIuRo2ePlHNYAhFgHB9uGTG boTuK3y2EhBKZfiA0QcweIX0m3ZoQ+Kj/u7Mug7p93Kk4V8GTcPS/6LYhCJDDw1jpoh8 +UgZTWOEn2qY9kIlNYvXul1UHLFViIMUsRJOXLJnWqG5lg3bViDhgiQr/For0ZisES0B wX3IAQ/a3my3SmtOcoDbvTyoKzEILVcwF0BE0wDrFhdq3aXok6TxM6o7Slaxz57ecukp xJQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de12si6765670ejc.296.2021.06.12.00.19.33; Sat, 12 Jun 2021 00:19:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230400AbhFLHUl (ORCPT + 99 others); Sat, 12 Jun 2021 03:20:41 -0400 Received: from smtp13.smtpout.orange.fr ([80.12.242.135]:55217 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230115AbhFLHUj (ORCPT ); Sat, 12 Jun 2021 03:20:39 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d74 with ME id G7Jc2500P21Fzsu037Jd1X; Sat, 12 Jun 2021 09:18:38 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 12 Jun 2021 09:18:38 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: subbu.seetharaman@broadcom.com, ketan.mukadam@broadcom.com, jitendra.bhivare@broadcom.com, jejb@linux.ibm.com, martin.petersen@oracle.com, minhduc.tran@emulex.com, sony.john-n@emulex.com, JBottomley@Parallels.com, jayamohank@gmail.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH 1/2] scsi: be2iscsi: Fix an error handling path in 'beiscsi_dev_probe()' Date: Sat, 12 Jun 2021 09:18:34 +0200 Message-Id: <77adb02cfea7f1364e5603ecf3930d8597ae356e.1623482155.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 3567f36a09d1 ("[SCSI] be2iscsi: Fix AER handling in driver") Signed-off-by: Christophe JAILLET --- drivers/scsi/be2iscsi/be_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c index 310b801c6c87..b89a7db477c7 100644 --- a/drivers/scsi/be2iscsi/be_main.c +++ b/drivers/scsi/be2iscsi/be_main.c @@ -5743,6 +5743,7 @@ static int beiscsi_dev_probe(struct pci_dev *pcidev, pci_disable_msix(phba->pcidev); pci_dev_put(phba->pcidev); iscsi_host_free(phba->shost); + pci_disable_pcie_error_reporting(pcidev); pci_set_drvdata(pcidev, NULL); disable_pci: pci_release_regions(pcidev); -- 2.30.2