Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1336040pxj; Sat, 12 Jun 2021 05:41:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyYp2BtAGg31tJiKdUlUI/F2FjNyKuHsN51CNHmpuYGWo4YDf0/vaCdQgptUvzDiHuMTZxF X-Received: by 2002:a17:906:4e05:: with SMTP id z5mr7603412eju.520.1623501671050; Sat, 12 Jun 2021 05:41:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623501671; cv=none; d=google.com; s=arc-20160816; b=qlGAWaXjY4gLSHYSDk+aoiEhUXBPMNay1vMBNLVwbhob1jSzf9HOoxQRnP7NvKde/Z FNZkmyPB23pGt38OhndJJYcIgJ+MTZd3qeQoJxAnNhv3WDC9P42t18ITivfZ6VUo1ne6 //Wq8yvhwGTfHHA5ffrXeqZdG+A110hmT/fv3ujm0K3ZDN+MNBVGLLH8qZ+pFz9ZWwJJ 0jcW4gr4pjidaZYv3mRgsHaK8+Emey5VkHBQeuEyviAT30X7gUpjpT6mQeiHLn5bX1dP A2OXwNj/YVxnlZtv1M199Oq7fYm51qx7bCnaIjhHpJVs3dTjvOnb667DG3Qb6KVs9f+B Oknw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=kf9zkB4h/DcuUDjh6kOCkqFYn/VYmtkLNGdAAooMGs0=; b=yaPvrnyhhY84DeYRirKG8fi8RGZcTPE8NMHDfDPzwlU+itkbHxPSMRGhy1PaYTS8qx RRsXHp9k+fjM03Qi1wMDUlAt5pdJpbvRm11YzpLy1STcA3V77wKV5zgIVoHUngKVE3Bs THS68ZUiBENF7AIs8kSTpB2WgyXyEs+JzxgPPC6dto3AhM5DH54qRw6Y/TYr0zkkuNid 9BQzXYRaf0/AwiHbZMgGiLssxH2CyoNLPu3WevnZGNDh3zvtoFOWQlvVO2zdFUjZ6HgP 1Gtt1gDgU8whMcUUvrAsPZHfcMy88gF5M2ihnL+XKeJCID/h5VOyS1oWStqC9tR2s+ez E3Kw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f22si7056123ejj.302.2021.06.12.05.40.47; Sat, 12 Jun 2021 05:41:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231479AbhFLMj4 (ORCPT + 99 others); Sat, 12 Jun 2021 08:39:56 -0400 Received: from smtp08.smtpout.orange.fr ([80.12.242.130]:26294 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231336AbhFLMjw (ORCPT ); Sat, 12 Jun 2021 08:39:52 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d43 with ME id GCdp2500621Fzsu03CdpjX; Sat, 12 Jun 2021 14:37:51 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 12 Jun 2021 14:37:51 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: shshaikh@marvell.com, manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com, davem@davemloft.net, kuba@kernel.org, amit.salecha@qlogic.com, sucheta.chakraborty@qlogic.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] qlcnic: Fix an error handling path in 'qlcnic_probe()' Date: Sat, 12 Jun 2021 14:37:46 +0200 Message-Id: <2b582e7e0f777ad2a04f9d0568045bee1483a27f.1623501317.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 451724c821c1 ("qlcnic: aer support") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c index 8966f1bcda77..918220ad0d53 100644 --- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c @@ -2690,6 +2690,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent) kfree(ahw); err_out_free_res: + pci_disable_pcie_error_reporting(pdev); pci_release_regions(pdev); err_out_disable_pdev: -- 2.30.2