Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: bcain=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org EAC33C433D3
Reply-To: <bcain@codeaurora.org>
From:   "Brian Cain" <bcain@codeaurora.org>
To:     "'Christophe Leroy'" <christophe.leroy@csgroup.eu>,
        "'Chris Mason'" <clm@fb.com>
Cc:     "'Josef Bacik'" <josef@toxicpanda.com>,
        "'David Sterba'" <dsterba@suse.com>,
        <linux-kernel@vger.kernel.org>, <linuxppc-dev@lists.ozlabs.org>,
        "'linux-btrfs'" <linux-btrfs@vger.kernel.org>,
        <linux-hexagon@vger.kernel.org>
References: <a16c31f3caf448dda5d9315e056585b6fafc22c5.1623302442.git.christophe.leroy@csgroup.eu> <185278AF-1D87-432D-87E9-C86B3223113E@fb.com> <cdadf66e-0a6e-4efe-0326-7236c43b2735@csgroup.eu>
In-Reply-To: <cdadf66e-0a6e-4efe-0326-7236c43b2735@csgroup.eu>
Subject: RE: [PATCH] btrfs: Disable BTRFS on platforms having 256K pages
Date:   Sat, 12 Jun 2021 09:44:05 -0500
Message-ID: <17a401d75f99$662cdc50$328694f0$@codeaurora.org>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: en-us
Thread-Index: AQFXZSsKSQYV21VAkXhEQlQXq32SZQKLFB0ZAuYFiEqr5N8nYA==
Precedence: bulk


> -----Original Message-----
> From: Christophe Leroy <christophe.leroy@csgroup.eu>
...
> Le 10/06/2021 =C3=A0 15:54, Chris Mason a =C3=A9crit :
> >
> >> On Jun 10, 2021, at 1:23 AM, Christophe Leroy
> <christophe.leroy@csgroup.eu> wrote:
> >>
> >> With a config having PAGE_SIZE set to 256K, BTRFS build fails
> >> with the following message
> >>
> >> include/linux/compiler_types.h:326:38: error: call to
> '__compiletime_assert_791' declared with attribute error: BUILD_BUG_ON
> failed: (BTRFS_MAX_COMPRESSED % PAGE_SIZE) !=3D 0
> >>
> >> BTRFS_MAX_COMPRESSED being 128K, BTRFS cannot support platforms
> with
> >> 256K pages at the time being.
> >>
> >> There are two platforms that can select 256K pages:
> >> - hexagon
> >> - powerpc
> >>
> >> Disable BTRFS when 256K page size is selected.
> >>
> >
> > We=E2=80=99ll have other subpage blocksize concerns with 256K pages, =
but this
> BTRFS_MAX_COMPRESSED #define is arbitrary.  It=E2=80=99s just trying =
to have an
> upper bound on the amount of memory we=E2=80=99ll need to uncompress a =
single
> page=E2=80=99s worth of random reads.
> >
> > We could change it to max(PAGE_SIZE, 128K) or just bump to 256K.
> >
>=20
> But if 256K is problematic in other ways, is it worth bumping
> BTRFS_MAX_COMPRESSED to 256K ?
>=20
> David, in below mail, said that 256K support would require deaper =
changes. So
> disabling BTRFS
> support seems the easiest solution for the time being, at least for =
Stable (I
> forgot the Fixes: tag
> and the CC: to stable).
>=20
> On powerpc, 256k pages is a corner case, it requires customised =
binutils, so I
> don't think disabling
> BTRFS is a issue there. For hexagon I don't know.

Larger page sizes like this are typical for hexagon.  Disabling btrfs on =
hexagon seems appropriate.

-Brian