Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1578018pxj; Sat, 12 Jun 2021 13:02:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxS8FoHUQVsl8i4w/ec0019I+AulwhzJBVgTxiEb0j9ILNSMGd9z9F9e3uXFYGkVCA0P/+d X-Received: by 2002:a05:6402:1593:: with SMTP id c19mr9946261edv.66.1623528169316; Sat, 12 Jun 2021 13:02:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623528169; cv=none; d=google.com; s=arc-20160816; b=cql8A0lEZjEIiJpQRNmr2Ye9D+xwwrCbERjf6Rfm1Emgo+/u6UbIgAMKYRMUqnae59 ZfofDHz6mOc7EDrgn53BU5b4Fqn6ahOssj9MKDU9UfFHcCE5/x8mK1C2xbMsN3x5PYFg bebbSVb4prZav1IkSL5myuV7gqb02fU2D1o9fmV0LZ7JoYqjbcj2PwMtSQFhozvHmXTM TNppqv1NyjbaPJU+HnkvPmrE5/DBOY6MnXe1d+iRa3hTtjHLhsxmsVp2tbneYMcxnfi0 17IL64u2hqjCHBVZEaCRtxOtxa1syXNyKxST3Ze/McZ7QPz3598gyD52GyA5tdSKeHeJ 1/cQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=SvS6FbdZ4HKCsIzRXBNtTlBB7Mf12TGsuRtKZvfkfZ8=; b=zJQKTIc0FIhN2aJE25SZlkmK3Ol/cOdeMubl8ZAMyWde1zefUXAtZrnu42pt3PYS4X YTypDslvglsxspGablK1NWvi/GFYlmwKO0p+cOUwrT7tpk4sMlYqUy/x8TF9emdYUbnh EtzzseVVL+rQkvTNAXjfhVCoQ3t6qtg7EFwf9Q8doxt8jM44F2htFLjWpZTpY+ark9mj 365Nbw5BDTvrufrXaaCP27MToJsy0svFqycLnsnGkVEs9ORN8Qo1nieFEFTokAcXeQhO 9rTbOJI/V3WhlTgNz7tNLMpe0P9KchALleT436sUMhO+rxLbALiXB/P9YwK8Kh18Iws+ wIbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 7si8200460ejg.355.2021.06.12.13.02.25; Sat, 12 Jun 2021 13:02:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231408AbhFLUCN (ORCPT + 99 others); Sat, 12 Jun 2021 16:02:13 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:26934 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229874AbhFLUCM (ORCPT ); Sat, 12 Jun 2021 16:02:12 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d33 with ME id GL062500J21Fzsu03L07KJ; Sat, 12 Jun 2021 22:00:11 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 12 Jun 2021 22:00:11 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, jeffrey.t.kirsher@intel.com, sasha.neftin@intel.com Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] igc: Fix an error handling path in 'igc_probe()' Date: Sat, 12 Jun 2021 22:00:05 +0200 Message-Id: X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: c9a11c23ceb6 ("igc: Add netdev") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/intel/igc/igc_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index 3f6b6d4543a8..6389a41cacc1 100644 --- a/drivers/net/ethernet/intel/igc/igc_main.c +++ b/drivers/net/ethernet/intel/igc/igc_main.c @@ -6057,6 +6057,7 @@ static int igc_probe(struct pci_dev *pdev, err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2