Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp1582966pxj; Sat, 12 Jun 2021 13:13:07 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxW6GTJwDGcqVT21XErWnfy7lI90lPI4OotW+HsMdKfEsnY859gtFxGWgq8C3ZvLvDwslNO X-Received: by 2002:a05:6402:214:: with SMTP id t20mr10069481edv.20.1623528787732; Sat, 12 Jun 2021 13:13:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623528787; cv=none; d=google.com; s=arc-20160816; b=BVdBeuDAGAdY2/4U70Yiqn70l5kFrDMMHDEnvmCC/vCtZOSB1KMM62tYoMu1xNwJF2 t5wnZO7luDKBB2dpLYlX90JJYiaxIKiEPW2xPzpMPb8ZU4tt+pHfWK6+I028eowwbX1q y6OlX3PIWuwhRLzj4OiSkvMhvisV6V1xNd84wZ2UIZ5TuK6qNz3Q4RZ5F/ZiqUNaukG4 RrvHmCAIytUcHkU4Xm6BJuGWBbhgv9cONe6Pgc4Vgh13iKrktzKV0OD31OsA6tNW8fi/ e9ahegte2qygT6+JCuLmlhxuz/eVS9DrsALviX3CTYHSpPh0f1NocR9myovcyo8Q/1XJ sufw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=/Vbr33WKU1r9nMLfG+Mr8xlaGXdQ2scdBto+AFcdbGY=; b=k3V62Hh7CZkvg6hffgW4aBx7nZavfY6PRE9/O79TcrUxqnp7xecPNEGWQBk3ZT+fKE Ars3LPwK1NwDmAk52YNlZ9ItaGT1Wr5xWcxffLBqzzODskZeF/3eQfvkOW9hZvQl3hRr JCXImyOp9mf/0fnZbqt1IyBurRCGyhnMR8mjNwTv3+RyQMqyZTwWvtg/P90SqAgnxkG/ SKpOXN0TvVZa57xmcNLkP+cwwrBJH5fmu8SZr5KLyGflwvsKL1ljGuhU1wyQuR/F5Am6 xNFCQQby1Pk6XJGzVQKdgT0HdYrT9yPK+YfMhPcbQMxOES6p0lfFffbBdaeOm31bNMup htNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o20si7933760ejm.286.2021.06.12.13.12.44; Sat, 12 Jun 2021 13:13:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231484AbhFLUKi (ORCPT + 99 others); Sat, 12 Jun 2021 16:10:38 -0400 Received: from smtp03.smtpout.orange.fr ([80.12.242.125]:25570 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230492AbhFLUKf (ORCPT ); Sat, 12 Jun 2021 16:10:35 -0400 Received: from localhost.localdomain ([86.243.172.93]) by mwinf5d33 with ME id GL8a2500G21Fzsu03L8aoJ; Sat, 12 Jun 2021 22:08:35 +0200 X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 12 Jun 2021 22:08:35 +0200 X-ME-IP: 86.243.172.93 From: Christophe JAILLET To: jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com, davem@davemloft.net, kuba@kernel.org, jeffrey.t.kirsher@intel.com, alexander.h.duyck@intel.com Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET Subject: [PATCH] igb: Fix an error handling path in 'igb_probe()' Date: Sat, 12 Jun 2021 22:08:33 +0200 Message-Id: <0b5cab7b74ca2544d3c616da89f50635e827bc6f.1623528463.git.christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it must be undone by a corresponding 'pci_disable_pcie_error_reporting()' call, as already done in the remove function. Fixes: 40a914fa72ab ("igb: Add support for pci-e Advanced Error Reporting") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 5db303d64d14..cf1de2b9ab71 100644 --- a/drivers/net/ethernet/intel/igb/igb_main.c +++ b/drivers/net/ethernet/intel/igb/igb_main.c @@ -3615,6 +3615,7 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent) err_ioremap: free_netdev(netdev); err_alloc_etherdev: + pci_disable_pcie_error_reporting(pdev); pci_release_mem_regions(pdev); err_pci_reg: err_dma: -- 2.30.2