Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: W81W2S2Smv1m7lWEePHeaCF8Yboe92XIC9/8Soa2wYdDA1RN7HskugcSCQ7JSN4vH2pRshnNEp
 uyfZHOaB0ZCBgYaWIxGguEJsVP1oQQ7uxOooMn7fgMU4dbB2vNmkiVmV07DaTN0Cl4Njvy2/4S
 xDeo8oYWCwYd+eB+p8bsdZTvl195lHCOkQ4doKZclVTTfqoN+K1oGWpGzOuWTlvXg1YPRHKrW1
 8xoNFsGodb9ic7LHfge6rTnZY4hD7hgytGG9/lJ5xVo13gpiv8eaIl9pm0cT2cmXE7p1moyT7z
 ekE=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     "yohan.joung@sk.com" <yohan.joung@sk.com>,
        "daejun7.park@samsung.com" <daejun7.park@samsung.com>
CC:     "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "d_hyun.kwon@samsung.com" <d_hyun.kwon@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "huobean@gmail.com" <huobean@gmail.com>,
        "j-young.choi@samsung.com" <j-young.choi@samsung.com>,
        "jaemyung.lee@samsung.com" <jaemyung.lee@samsung.com>,
        "javier.gonz@samsung.com" <javier.gonz@samsung.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "jh.i.park@samsung.com" <jh.i.park@samsung.com>,
        "jieon.seol@samsung.com" <jieon.seol@samsung.com>,
        "keosung.park@samsung.com" <keosung.park@samsung.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "sungjun07.park@samsung.com" <sungjun07.park@samsung.com>,
        "jaeyoung21.choi@sk.com" <jaeyoung21.choi@sk.com>
Subject: RE: [PATCH v37 3/4] scsi: ufs: Prepare HPB read for cached sub-region
Thread-Topic: [PATCH v37 3/4] scsi: ufs: Prepare HPB read for cached
 sub-region
Thread-Index: AddefoShGrvD08D4TZWSbfCJbPtUOgBvsB1Q
Date:   Sun, 13 Jun 2021 10:20:53 +0000
Message-ID: <DM6PR04MB65752E6128BD92A801221ECDFC329@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <29bb775275b941c08c3f3f0d835620fe@sk.com>
In-Reply-To: <29bb775275b941c08c3f3f0d835620fe@sk.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?PryAA6Pankqd5MfZD9NVsWDCpGycxbvNVJzxKeKueEGgtk7nhVJAr4cLbDtS?=
 =?us-ascii?Q?azDkO9qyeufbh+58OtU5bXq0i19t+LJLGRNujRABNzc/C3XT5K2xHNxbpYJh?=
 =?us-ascii?Q?v2B+7iXzYhhnzMUDZ6TCWSVDrQ3opNX9oAMwLpJEbhNW3tEmW4Jl0g9wem2/?=
 =?us-ascii?Q?xhgQMVyNv6lC4XwITcGEiNRcASLGWpUkgirPa61RUFkHvqU7qgMQkODXoxxw?=
 =?us-ascii?Q?bd0a3s9SUYPtn/18135+HQwtzOeaET2vbE9/CDBbIoU5q8hatjtHFMwx1FgA?=
 =?us-ascii?Q?0xVlyLDDcc8kaMbb5SXMt1nPMEvuVg71lz9Si+9+ivLxe/NVt992kJRHFC8N?=
 =?us-ascii?Q?ydsh/xaYzZie3XOCRFYex5Oa7grn1X25UY3UnfGFlnUKhdVefyg6RivoLDDp?=
 =?us-ascii?Q?XhEelNBMcDb9mPUIAqEorCGWbIgxGZp7drlAInoBGU/dsa7BdWJWR9S6axNc?=
 =?us-ascii?Q?gzAEK0If0RcilF5O4peFyQgyupNg2t0EVAMIFDrXrRWnWxH2DA/jCBNa9jJb?=
 =?us-ascii?Q?nyqB57meMSCAmF98atR0WjFQl97PmvGnexH59mCv3suTWvGi5CjaoWfNnE4J?=
 =?us-ascii?Q?i3sLhxF9tFU0o52qq9ZTBFcDCI2oaP7ZDZsXyQbqE5/X+JtSQfCrQkL3cq8L?=
 =?us-ascii?Q?iJhkO8B5Q9nVn97lv9aaXAzVaV1UdRq/r2KwLheHPX8nDM6mHExXHybcsbRY?=
 =?us-ascii?Q?SLc33N/LxHf2/ykE8eZzN436O3ro/HifH9fh6btxVODwvkg2PJ1AUMudaD8D?=
 =?us-ascii?Q?jmk3KA2k3i2y6ypxONHYlDeNMEQ4YJgWOmNOfz7kuFHuACn7sISdg/D9zBCW?=
 =?us-ascii?Q?2bkedPOzLKVVzDzyNgGs11PD9f5jCXkjlX5ytjNk3/ep33HIpMtOntuaZAT4?=
 =?us-ascii?Q?aopT5SXt/8ga1eiDCVBh1+j1bf8cFSYGx5DL5WiNVXWBP3sooWRIhCyXP1vb?=
 =?us-ascii?Q?woFhPwJpFn+qi7LZVltMUkMy5UzseLiFeQWfIkWXYFajOQKT0DblIR6M0npF?=
 =?us-ascii?Q?q4Ia+xoNUNZPKmGw59s3U2bu5yRf12GcxM1K39pEwQ3Am53QEPBMnbJecocU?=
 =?us-ascii?Q?/UbAi5hApptcIxjkbus30CfmoQ3AOBosTgYVLw920js3FSfeC1VCiQY8QCPp?=
 =?us-ascii?Q?sVG+2OfNkT7lPoqGKPsTHHDcohido5oOOYcDbwko9XtiOdx2h3wriYPCy22+?=
 =?us-ascii?Q?G7PnPbrV6JEgkO/JHLhQX1u9K/o7WfL3i7Et3oMyh8RDy3qIi2Bu8Ioj9Ife?=
 =?us-ascii?Q?+ot1pSblUSazE364EvgE1AhoZk8w+59hFLUaPMv5Bytk6sCgHHFuBhWJXg1D?=
 =?us-ascii?Q?v3F/dHXQOQrS33lw58BAcm4h?=
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR04MB6575.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 38521a95-b5ed-4ef5-7ac1-08d92e54ecf5
X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jun 2021 10:20:53.5395
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ezjSvjy/n3tGTq4rIpXqIDqU2ACMXeLqVuQSrhN6u5feOCJE3jz8QZeO33Xt3fhoBBdcV4vCmEfGX/IayvwjmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1098
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> >+      /*
> >+       * If the region state is active, mctx must be allocated.
> >+       * In this case, check whether the region is evicted or
> >+       * mctx allcation fail.
> >+       */
> >+      if (unlikely(!srgn->mctx)) {
> >+              dev_err(&hpb->sdev_ufs_lu->sdev_dev,
> >+                      "no mctx in region %d subregion %d.\n",
> >+                      srgn->rgn_idx, srgn->srgn_idx);
> >+              return true;
> >+      }
> >+
> >+      if ((srgn_offset + cnt) > bitmap_len)
> >+              bit_len =3D bitmap_len - srgn_offset;
> >+      else
> >+              bit_len =3D cnt;
> >+
> >+      if (find_next_bit(srgn->mctx->ppn_dirty, bitmap_len,
> >+                        srgn_offset) < bit_len + srgn_offset)
> >+              return true;
> >+
>=20
> It seems unnecessary to search through bitmap_len
> How about searching by transfer size?
>=20
> if (find_next_bit(srgn->mctx->ppn_dirty,
>               bit_len + srgn_offset, srgn_offset) < bit_len + srgn_offset=
)
Isn't bit_len should be used for size, and not bit_len + srgn_offset ?

Thanks,
Avri

>=20
> Thanks
> Yohan