Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210611093626.579176-1-yangyingliang@huawei.com> <20210611093626.579176-10-yangyingliang@huawei.com>
In-Reply-To: <20210611093626.579176-10-yangyingliang@huawei.com>
From:   Timur Tabi <timur@kernel.org>
Date:   Sun, 13 Jun 2021 09:00:25 -0500
Message-ID: <CAOZdJXUn9FgdhiPAqbxMrz4tSeqQ_S+L9jkpg48NxCo5Fz7PXQ@mail.gmail.com>
Subject: Re: [PATCH -next 9/9] ASoC: fsl_xcvr: check return value after
 calling platform_get_resource_byname()
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     lkml <linux-kernel@vger.kernel.org>,
        PowerPC Mailing List <linuxppc-dev@lists.ozlabs.org>,
        alsa-devel mailing list <alsa-devel@alsa-project.org>,
        timur@kernel.org, Mark Brown <broonie@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jun 11, 2021 at 4:32 AM Yang Yingliang <yangyingliang@huawei.com> wrote:

>         rx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "rxfifo");
>         tx_res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "txfifo");
> +       if (!rx_res || !tx_res) {
> +               dev_err(dev, "Invalid resource\n");
> +               return -EINVAL;
> +       }

If platform_get_resource_byname() returns an error, it's probably
because the name cannot be found.  So I think this error message is
more accurate:

"could not find rxfifo or txfifo resource"