Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2191449pxj; Sun, 13 Jun 2021 11:45:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaq8ePODpIoTzc4oNP47e8osbX0BQf5iROZPF5sLyCSApgPcp2W0K3iHJZPPmkik/JypIA X-Received: by 2002:a17:906:2988:: with SMTP id x8mr12383520eje.122.1623609932023; Sun, 13 Jun 2021 11:45:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623609932; cv=none; d=google.com; s=arc-20160816; b=ydeulitqoVJzX+tE9FXHx6zPUylaUpSaIM+wcHKVq2gDIu6SsQLbueCnqnukrg9+tF MNOJ19k6IYIClC3lXLvP5164z4/yxbeRPmU54APPYUgG8HADvJZKrmNSH4idxnmwg+na ECcSYBYfa4S6R/TDj3rvEwWKBx6hLnDyTU6qzuHiPm0Zo+UTRImG1KJjAvI9SZ2y0ZRO slMamw/BLaHXCjL+d7xbiiFNEJZg3Zjgsg2W+vtyfGv0kG4erumz5AfhJ+VkoKzKSNCW 0KgrqmzPvgwDxg/zetBoQO6+it0WyxceSKb343i+egbpGFC3LOkjbFdxbckbH6VPZ6Px Ll/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=zd0ykvRTbEDpr2q2WgUG100JamY8WG7iW9Jws5t14Yc=; b=jWdVVT4HB1P5O1bs7fdWN46e36DZsAFhYciU11vXHJ+XYDjiy9Z34CzID8ZUCXvpmB 8KakPM8aERL/KWSdybCdmgAB0juzHPAIpCIQZTaMebP7GpEYABPvjhx0IUC3kVyG56BM e/6ThXHy13jrgswwVL7FvPpxbzt55d2c1Tyy6iFuvxLV6k9NnuXwSWZkQSA9CkOKR3fj Qo3aS+B0vB9QPByAlXsO5s7HD6SR2oV0BLIw8aXvW5Gf8/Lo98Xye8Jd1+9URsYfLlD3 JXp/33P/0Ncgz++thpMSzz1O5RmeShomHZp/WWmQ41J9vmxLLlwyyPXGImA7vlIk2Jp/ v8PQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=C0a5LoW6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n5si9627820edy.188.2021.06.13.11.45.09; Sun, 13 Jun 2021 11:45:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=C0a5LoW6; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232039AbhFMSqS (ORCPT + 99 others); Sun, 13 Jun 2021 14:46:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbhFMSqS (ORCPT ); Sun, 13 Jun 2021 14:46:18 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2C95C061574; Sun, 13 Jun 2021 11:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zd0ykvRTbEDpr2q2WgUG100JamY8WG7iW9Jws5t14Yc=; b=C0a5LoW6hFM+jmDI7Ejooc5Ot swqQSr8yHOXmKy6c7Hdu3ure1bUTpBsdVtyOJYtNCMjEjgsvWUjM+sVb1a9Eix/bytRECO+5uKYJd mGNQAHcp1aAgkjZkqWqwmOfOeKi0RdqHT7F18kp3MC5P69LFZIOI3TW399IGymE78osRTN4OeqqBq fBOyuQnwxEMCVv2F/xysisyiXK8Cd3ha3MRq78GZ1HdtEVKw3eT5y2EPoyngHB3MUsp1/dCBhoUdL lMldUTRynEcuIfB+RKVrPdkeEGKktKYXKqy8EIsl+xmcXeeoqIbeqbfB9XSZjlZVhk5IhRu+y+UF9 luaNsTeZg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:44982) by pandora.armlinux.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lsV5g-0003Zw-Ii; Sun, 13 Jun 2021 19:44:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.92) (envelope-from ) id 1lsV5d-0003OV-W4; Sun, 13 Jun 2021 19:44:10 +0100 Date: Sun, 13 Jun 2021 19:44:09 +0100 From: "Russell King (Oracle)" To: Marcin Wojtas Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, jaz@semihalf.com, gjb@semihalf.com, upstream@semihalf.com, Samer.El-Haj-Mahmoud@arm.com, jon@solid-run.com Subject: Re: [net-next: PATCH 2/3] net: mvpp2: enable using phylink with ACPI Message-ID: <20210613184409.GQ22278@shell.armlinux.org.uk> References: <20210613183520.2247415-1-mw@semihalf.com> <20210613183520.2247415-3-mw@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210613183520.2247415-3-mw@semihalf.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 13, 2021 at 08:35:19PM +0200, Marcin Wojtas wrote: > > /* Phylink isn't used w/ ACPI as of now */ > - if (port_node) { > + if (!mvpp2_use_acpi_compat_mode(port_fwnode)) { Does this comment need to be updated? -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!