Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH 2/4] ARM: dts: NSP: disable sp804 ccbtimers by default
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Vladimir Oltean <olteanv@gmail.com>, Andrew Lunn <andrew@lunn.ch>,
        Vivek Unune <npcomplete13@gmail.com>,
        Rob Herring <robh+dt@kernel.org>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>,
        bcm-kernel-feedback-list@broadcom.com, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
References: <20210613094639.3242151-1-mnhagan88@gmail.com>
 <20210613094639.3242151-2-mnhagan88@gmail.com>
 <89d2a415-a9a3-f778-bd40-e39e01e219ef@gmail.com>
From:   Matthew Hagan <mnhagan88@gmail.com>
Message-ID: <58b60b8f-6c86-f44f-38d2-fc260aa59de0@gmail.com>
Date:   Sun, 13 Jun 2021 20:46:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.11.0
MIME-Version: 1.0
In-Reply-To: <89d2a415-a9a3-f778-bd40-e39e01e219ef@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

On 13/06/2021 17:22, Florian Fainelli wrote:

>
> On 6/13/2021 2:46 AM, Matthew Hagan wrote:
>> The sp804 ccbtimers are enabled by default, however they may or may not
>> be present on the board. This patch disables them by default, requiring
>> them to be enabled only where applicable.
> The timers are always part of the SoC, so they should always be enabled,
> and if there was some board specific wiring, in that maybe one of the
> times was fed a different clock source than iprocslow, we could deal
> with that on a per-board basis.
>
> If someone does not want a specific timer to be used, it could be
> unbound once the kernel has booted for instance.

I should have spent more time to look at the issue rather rather than
proposing to disable parts of the SoC.

In my case with ccbtimer0, ccbtimer1 both enabled:

[    0.000181] clocksource: arm,sp804: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 15290083572 ns
[    0.000209] Failed to initialize '/axi@18000000/timer@35000': -22

but with ccbtimer0 disabled, ccbtimer1 now initialises correctly:

[    0.000186] clocksource: arm,sp804: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 15290083572 ns

Will investigate this further, but yes this patch should be dropped.

Thanks,
Matthew