Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA
 mode build options
To:     Lu Baolu <baolu.lu@linux.intel.com>, <joro@8bytes.org>,
        <will@kernel.org>, <dwmw2@infradead.org>, <robin.murphy@arm.com>
CC:     <linux-kernel@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
        <linuxarm@huawei.com>, <thunder.leizhen@huawei.com>,
        <chenxiang66@hisilicon.com>
References: <1623414043-40745-1-git-send-email-john.garry@huawei.com>
 <1623414043-40745-4-git-send-email-john.garry@huawei.com>
 <4f2cec34-bad9-e1bf-85c1-04d1a0c1aecf@linux.intel.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <6055cd0d-a1d3-a73a-6831-3837021f3c9c@huawei.com>
Date:   Mon, 14 Jun 2021 08:53:08 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <4f2cec34-bad9-e1bf-85c1-04d1a0c1aecf@linux.intel.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/06/2021 03:22, Lu Baolu wrote:
> On 2021/6/11 20:20, John Garry wrote:
>> @@ -453,8 +452,7 @@ static int __init intel_iommu_setup(char *str)
>>               pr_warn("intel_iommu=forcedac deprecated; use 
>> iommu.forcedac instead\n");
>>               iommu_dma_forcedac = true;
>>           } else if (!strncmp(str, "strict", 6)) {
>> -            pr_info("Disable batched IOTLB flush\n");
>> -            intel_iommu_strict = 1;
>> +            iommu_set_dma_strict(true);
> 
> I would like to deprecate this command line and ask users to use
> iommu.strict instead.

ok, but then I should probably make the AMD driver also officially 
support this.

> 
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -436,7 +436,7 @@ static int __init intel_iommu_setup(char *str)
>                          pr_warn("intel_iommu=forcedac deprecated; use 
> iommu.forcedac instead\n");
>                          iommu_dma_forcedac = true;
>                  } else if (!strncmp(str, "strict", 6)) {
> -                       pr_info("Disable batched IOTLB flush\n");
> +                       pr_warn("intel_iommu=strict deprecated; use 
> iommu.strict instead\n");
>                          intel_iommu_strict = 1;
> 
> Also update Documentation/admin-guide/kernel-parameters.txt accordingly.

Thanks,
John