Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <e0d146b034576c755cb98018159fa30f8dba2101.1623476278.git.christophe.jaillet@wanadoo.fr>
In-Reply-To: <e0d146b034576c755cb98018159fa30f8dba2101.1623476278.git.christophe.jaillet@wanadoo.fr>
From:   Oded Gabbay <oded.gabbay@gmail.com>
Date:   Mon, 14 Jun 2021 11:48:49 +0300
Message-ID: <CAFCwf109JLqs+Qb5MUDEjG6EXK09JmH+bJjDXvLhNXOrr2aF3A@mail.gmail.com>
Subject: Re: [PATCH] habanalabs: Fix an error handling path in 'hl_pci_probe()'
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc:     Oded Gabbay <ogabbay@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ofir Bitton <obitton@habana.ai>,
        Omer Shpigelman <oshpigelman@habana.ai>,
        farah kassabri <fkassabri@habana.ai>,
        "Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
        kernel-janitors@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jun 12, 2021 at 8:42 AM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If an error occurs after a 'pci_enable_pcie_error_reporting()' call, it
> must be undone by a corresponding 'pci_disable_pcie_error_reporting()'
> call, as already done in the remove function.
>
> Fixes: 2e5eda4681f9 ("habanalabs: PCIe Advanced Error Reporting support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
>  drivers/misc/habanalabs/common/habanalabs_drv.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c
> index 64d1530db985..d15b912a347b 100644
> --- a/drivers/misc/habanalabs/common/habanalabs_drv.c
> +++ b/drivers/misc/habanalabs/common/habanalabs_drv.c
> @@ -464,6 +464,7 @@ static int hl_pci_probe(struct pci_dev *pdev,
>         return 0;
>
>  disable_device:
> +       pci_disable_pcie_error_reporting(pdev);
>         pci_set_drvdata(pdev, NULL);
>         destroy_hdev(hdev);
>
> --
> 2.30.2
>

Thanks for catching it.
This patch is:
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>

Applied to -next.
Oded