Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2639571pxj; Mon, 14 Jun 2021 03:45:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQllwNvUvu3n/4X4ljUdFICu3ygii+7GfRKDr1QxbxNJrYnXSWRBDyvqRSxZEG8mo6/UuH X-Received: by 2002:a17:906:f744:: with SMTP id jp4mr14625610ejb.210.1623667537247; Mon, 14 Jun 2021 03:45:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623667537; cv=none; d=google.com; s=arc-20160816; b=Xz6+Mx34PO7bJwwEZBK9Vc+QdN18wlLqT2tc+vTcdUq3pAwoA8F5lA18qCRu5YWlgU Vx2TOIAwDpreDHiZqPLEHjbf8cGmD3RMNbE9mQjVul8NM6lQ23UU9DQSl5dKtoNx52tA PdCIlLI2n3Lg10Z+gYxBmSl2a7SsHK9Gj0XXIj9LC/HLy9k78j/5KWkREYmZR0AxODJl 9ovb7bJfuuJNz9ZOrdUeC0d/HiIhul5IGE/ZZobhTA7rEJfWnk7s9jiwhuoIMY+m8XoR 6Q0n3orLFl+SMt4h7dB6PRLmYFiUZt6VqO2j1I+dlZqJWvSjaDeW9uqLovhwIFXmUJN4 W0Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bdzUkWxU9wDpGB6MRqitCj3Xnt2pIHwToc5wzoCOQg0=; b=QBzk17kl5/ikCjv6vAUpg6NELBi+QwB/b9ouFOp+42/uM0B0qygGFNyVCc5JOgp8w6 y5E9u5ogOR/UgG5uPI4nfACDdNiLKE6Bkq610kMG17GSLmUwetr1g4WYb/K6Ou6VQbPP dEsxXpMIwpERQGiNz4zjzn48Df87ZlxrPZ1pVySnGaAcbd2nqXN2Y5v/qaHVcG7iHELa kXUQqa94WzfvgvzbobojYkYwvjt3mmhSRfIDZiHchLrUAshSd/P0WSXoOoakGjFLoJPw WPxmR5vlt/ya8qciRqEme+nwLN1PGLsUtPop0vlD7ZcXBuySe9eBbkBs/5KFZaSQCLEd bnSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h1EkgbJR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c1si10934604edv.260.2021.06.14.03.45.14; Mon, 14 Jun 2021 03:45:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=h1EkgbJR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233660AbhFNKpw (ORCPT + 99 others); Mon, 14 Jun 2021 06:45:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:46850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233900AbhFNKjI (ORCPT ); Mon, 14 Jun 2021 06:39:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BE8926141E; Mon, 14 Jun 2021 10:34:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623666851; bh=12MpSEjMAG8ZT1RiVEIWiStXoSQLE9uQJhQgUf+MVrg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h1EkgbJRjuP5J884dwIUhvFO8GskwE6cm0Zqbg2GWfFVVNLJEPDAYWKZL3nHgHhGu cnTFpavJi3tQEp+l83qPGfOGvJ1WaBIRfdm95uZ0ME5b+vEylkaMG0xLqCq8ZizYrk xmsl3CMkVODJGo4HBadrJFZtVjYIIXogwAAow5q0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Wenli Looi , Dan Carpenter Subject: [PATCH 4.14 24/49] staging: rtl8723bs: Fix uninitialized variables Date: Mon, 14 Jun 2021 12:27:17 +0200 Message-Id: <20210614102642.659213623@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210614102641.857724541@linuxfoundation.org> References: <20210614102641.857724541@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wenli Looi commit 43c85d770db80cb135f576f8fde6ff1a08e707a4 upstream. The sinfo.pertid and sinfo.generation variables are not initialized and it causes a crash when we use this as a wireless access point. [ 456.873025] ------------[ cut here ]------------ [ 456.878198] kernel BUG at mm/slub.c:3968! [ 456.882680] Internal error: Oops - BUG: 0 [#1] PREEMPT SMP ARM [ snip ] [ 457.271004] Backtrace: [ 457.273733] [] (kfree) from [] (nl80211_send_station+0x954/0xfc4) [ 457.282481] r9:eccca0c0 r8:e8edfec0 r7:00000000 r6:00000011 r5:e80a9480 r4:e8edfe00 [ 457.291132] [] (nl80211_send_station) from [] (cfg80211_new_sta+0x90/0x1cc) [ 457.300850] r10:e80a9480 r9:e8edfe00 r8:ea678cca r7:00000a20 r6:00000000 r5:ec46d000 [ 457.309586] r4:ec46d9e0 [ 457.312433] [] (cfg80211_new_sta) from [] (rtw_cfg80211_indicate_sta_assoc+0x80/0x9c [r8723bs]) [ 457.324095] r10:00009930 r9:e85b9d80 r8:bf091050 r7:00000000 r6:00000000 r5:0000001c [ 457.332831] r4:c1606788 [ 457.335692] [] (rtw_cfg80211_indicate_sta_assoc [r8723bs]) from [] (rtw_stassoc_event_callback+0x1c8/0x1d4 [r8723bs]) [ 457.349489] r7:ea678cc0 r6:000000a1 r5:f1225f84 r4:f086b000 [ 457.355845] [] (rtw_stassoc_event_callback [r8723bs]) from [] (mlme_evt_hdl+0x8c/0xb4 [r8723bs]) [ 457.367601] r7:c1604900 r6:f086c4b8 r5:00000000 r4:f086c000 [ 457.373959] [] (mlme_evt_hdl [r8723bs]) from [] (rtw_cmd_thread+0x198/0x3d8 [r8723bs]) [ 457.384744] r5:f086e000 r4:f086c000 [ 457.388754] [] (rtw_cmd_thread [r8723bs]) from [] (kthread+0x170/0x174) [ 457.398083] r10:ed7a57e8 r9:bf0367a4 r8:f086b000 r7:e8ede000 r6:00000000 r5:e9975200 [ 457.406828] r4:e8369900 [ 457.409653] [] (kthread) from [] (ret_from_fork+0x14/0x2c) [ 457.417718] Exception stack(0xe8edffb0 to 0xe8edfff8) [ 457.423356] ffa0: 00000000 00000000 00000000 00000000 [ 457.432492] ffc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 457.441618] ffe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 457.449006] r10:00000000 r9:00000000 r8:00000000 r7:00000000 r6:00000000 r5:c014a0a4 [ 457.457750] r4:e9975200 [ 457.460574] Code: 1a000003 e5953004 e3130001 1a000000 (e7f001f2) [ 457.467381] ---[ end trace 4acbc8c15e9e6aa7 ]--- Link: https://forum.armbian.com/topic/14727-wifi-ap-kernel-bug-in-kernel-5444/ Fixes: 8689c051a201 ("cfg80211: dynamically allocate per-tid stats for station info") Fixes: f5ea9120be2e ("nl80211: add generation number to all dumps") Signed-off-by: Wenli Looi Reviewed-by: Dan Carpenter Cc: stable Link: https://lore.kernel.org/r/20210608064620.74059-1-wlooi@ucalgary.ca Signed-off-by: Greg Kroah-Hartman --- drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c @@ -2432,7 +2432,7 @@ void rtw_cfg80211_indicate_sta_assoc(str DBG_871X(FUNC_ADPT_FMT"\n", FUNC_ADPT_ARG(padapter)); { - struct station_info sinfo; + struct station_info sinfo = {}; u8 ie_offset; if (GetFrameSubType(pmgmt_frame) == WIFI_ASSOCREQ) ie_offset = _ASOCREQ_IE_OFFSET_;