Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Jun 2021 11:34:46 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Alexander Sverdlin <alexander.sverdlin@gmail.com>
Cc:     Geert Uytterhoeven <geert@linux-m68k.org>,
        Nikita Shubin <nikita.shubin@maquefel.me>,
        linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] spi: spi-ep93xx: Prepare clock before using it
Message-ID: <20210614103446.GC5646@sirena.org.uk>
References: <20210613233041.128961-1-alexander.sverdlin@gmail.com>
 <20210613233041.128961-3-alexander.sverdlin@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Y5rl02BVI9TCfPar"
Content-Disposition: inline
In-Reply-To: <20210613233041.128961-3-alexander.sverdlin@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--Y5rl02BVI9TCfPar
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Jun 14, 2021 at 01:30:36AM +0200, Alexander Sverdlin wrote:
> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch
> to Common Clock Framework, otherwise the following is visible:
>=20
> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:1011 clk_core_enable+0x9c/0xbc
> Enabling unprepared ep93xx-spi.0
> CPU: 0 PID: 1 Comm: swapper Tainted: G        W         5.13.0-rc5-... #1
> Hardware name: Cirrus Logic EDB9302 Evaluation Board
> [<c000d5b0>] (unwind_backtrace) from [<c000c590>] (show_stack+0x10/0x18)
> [<c000c590>] (show_stack) from [<c03a5f38>] (dump_stack+0x20/0x2c)
> [<c03a5f38>] (dump_stack) from [<c03a2098>] (__warn+0x98/0xc0)
> [<c03a2098>] (__warn) from [<c03a2150>] (warn_slowpath_fmt+0x90/0xc0)
> [<c03a2150>] (warn_slowpath_fmt) from [<c01d8358>] (clk_core_enable+0x9c/=
0xbc)
> [<c01d8358>] (clk_core_enable) from [<c01d8698>] (clk_core_enable_lock+0x=
18/0x30)
> [<c01d8698>] (clk_core_enable_lock) from [<c023eeb4>] (ep93xx_spi_prepare=
_hardware+0x10/0x30)

Please think hard before including complete backtraces in upstream
reports, they are very large and contain almost no useful information
relative to their size so often obscure the relevant content in your
message. If part of the backtrace is usefully illustrative (it often is
for search engines if nothing else) then it's usually better to pull out
the relevant sections.

--Y5rl02BVI9TCfPar
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmDHMMUACgkQJNaLcl1U
h9DaVgf/WRx61EZX++GV5SmP8RyZsQsu8RLHH/fRsJLP77/QncSMK6AjFAx3Arjm
TKayaB2d06wkAPDXaXVPGu/ltYZRDcHo+vdBwG586kQgdzfagMSq/y4f4Q8V9r8w
NuVoVRvxjXAOPUUxsLJqhtlczeheW4fCIGRmbQyBnryipf/NgCRU0MSoAsTk5O8C
ILihHzbynhk3CZ9OZt8awIAIeq+/FesV7W+RcosHFeKNIPzWgTgrDcdelR/E4f06
7qbqZ3G4EXNyggvdusfKVTGINSOBKa5qk5HPuJu0766LiJi6o7wqA4Ay3bstjGmV
+PONN4/TXKsZEPDoc1644OZ6JeP82Q==
=IFes
-----END PGP SIGNATURE-----

--Y5rl02BVI9TCfPar--