Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2643039pxj; Mon, 14 Jun 2021 03:51:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyJ2ZAnHjO7Ss7urH8bPzhte9iDuand1XzA4vvze21bgEepv4qzeg793AmoOXQ/HecdFCY X-Received: by 2002:a17:906:f9d1:: with SMTP id lj17mr14834572ejb.345.1623667895862; Mon, 14 Jun 2021 03:51:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623667895; cv=none; d=google.com; s=arc-20160816; b=yFvGvm8RINV2Dswkg04DR9hJJrFTR42KxsqCJ4DZ9PU6gcguILL0/7FMrS8HfHiF4A plnmhA1ewDBa1FEJuJb6C+BiHQzDFRfR8DgnmUOHRYUW/hjKO3aBRqwOxPCwzN8QCw9Y u6GD9jlpo1tGdnQZB/z8KK0WUOysYFa7h8Tpf7x69VgTucUiXAI4RJ0Sq5ZeD11EzVaY nBoXWwLkxat7UbFAQWBoZIyIv4yzyUYzyybuk4aB7hQH1E1+/xSJpyGVO9qV3aXYonWN WW/RXm4JiIBbEy/FqUUDHjIkMQEvC9hXEG+BmpApN4FF7685DnWrgcB+kczDNQEvw48s kGuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=t8tImzhn4mt2Bdx1yGryZlS622DqjfPPKUNIeO0TdkA=; b=bCAqQ36aDlSpLaSqBlrgSwSxHod0EsMerOro1PIw6lXVRT3VXYpJO60D67fh2FhfYQ joS9WgVBDsBS99Bjs3BA9Z5n2Inwmcr5ilHc+AcNAVSVXoduB9lq0mZpA531JOsBS7AD hFwsc7ZPDPFfJIsb1XMdqKQ8nI6TNTkdA3p30u1PKBlVHqL41KfmzQstqheaxIYRigwW 5Jah1vSEELFLsPfegVL86FtDnnnQSs7wRXa4nqjI1rbvftC0y+alDFukJADef2Q9Rvh1 kOEuIBfVVuAk78y64v0PA+hcgM+6KDYA4vTfEpW6/xecOTYMjfBUsK4USGB9ujCraVt2 h9gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z0lnFjLv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cf15si5947408edb.548.2021.06.14.03.51.13; Mon, 14 Jun 2021 03:51:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Z0lnFjLv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234404AbhFNKvY (ORCPT + 99 others); Mon, 14 Jun 2021 06:51:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:47338 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234100AbhFNKoI (ORCPT ); Mon, 14 Jun 2021 06:44:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2D0E361449; Mon, 14 Jun 2021 10:36:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623666974; bh=qGD3Y7ReUnMxN25WHoGUXf+mJGZOYHKyzKSknSl+WtU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z0lnFjLvVT/5Jl6M7L2grGW7Ec9xSjiJtINFa8U/l2Heq80oxwx9+f5gPMHbqgm6A L75jB82FxUov+oRKrdD/d0RMp+NrIxxbIKkx0Hkh5wwdZjcJ8or3XwSw0x9r2D7EN3 PJcUe5LWRtZ/kiB9FZz7OY8873yVJzIZA+mEI/GQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Osipenko , Mark Brown Subject: [PATCH 4.19 50/67] regulator: max77620: Use device_set_of_node_from_dev() Date: Mon, 14 Jun 2021 12:27:33 +0200 Message-Id: <20210614102645.469259846@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210614102643.797691914@linuxfoundation.org> References: <20210614102643.797691914@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Osipenko commit 6f55c5dd1118b3076d11d9cb17f5c5f4bc3a1162 upstream. The MAX77620 driver fails to re-probe on deferred probe because driver core tries to claim resources that are already claimed by the PINCTRL device. Use device_set_of_node_from_dev() helper which marks OF node as reused, skipping erroneous execution of pinctrl_bind_pins() for the PMIC device on the re-probe. Fixes: aea6cb99703e ("regulator: resolve supply after creating regulator") Signed-off-by: Dmitry Osipenko Link: https://lore.kernel.org/r/20210523224243.13219-2-digetx@gmail.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/regulator/max77620-regulator.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/regulator/max77620-regulator.c +++ b/drivers/regulator/max77620-regulator.c @@ -792,6 +792,13 @@ static int max77620_regulator_probe(stru config.dev = dev; config.driver_data = pmic; + /* + * Set of_node_reuse flag to prevent driver core from attempting to + * claim any pinmux resources already claimed by the parent device. + * Otherwise PMIC driver will fail to re-probe. + */ + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + for (id = 0; id < MAX77620_NUM_REGS; id++) { struct regulator_dev *rdev; struct regulator_desc *rdesc;