Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2645128pxj; Mon, 14 Jun 2021 03:55:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxDPk3cn+AS17yjQHK0Cs5oon+0EIz+ZXi0MbYhlgsUNeCvQb2gHdp4fpfUnlpeOK/ht5Dn X-Received: by 2002:a17:906:a293:: with SMTP id i19mr14084154ejz.311.1623668119646; Mon, 14 Jun 2021 03:55:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623668119; cv=none; d=google.com; s=arc-20160816; b=bc8xNmjYbqSZiP8GoxHK12GOoG9ZfBbWGE92wr339A7Yc4F29mu/+YdTq30FyaB0LW hkhAfFRD7er1DN8EhbTlV+pEb4M81boBiTUvDIDMtcaxLVpC031rIzFS1dfFo4YcIQGT r/NthJYkU8qVE8rEL4tr2o4j2X/p+OdVZgvb1VD92jKcUAUHg23e8iYaQP7I/4Ny42H4 POOagpqbR3n5VbgUIQYULbzjii0J8ZGk/Ei0C6DFpBHCqbB9uviMAQXLQON+fFmnE7B7 rjRbuA/eeI8ZFs7ipT5ivaKZCsTMxjr1+TWASh59xb2F2rIhth094iUHM09BrWeAVYBY /wUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=E8ZZ/cEJPGh5polcbqgEyQrXCJoI83G0HpJBZJf6N/g=; b=mlaCmR6MFVxHKF0RXMA/M6KRHlID9ccvV7hwIJnmQ7NzoU0ua7nMXvIDI5nVrKlnJP Ao2tEDveqX8hNmpqqrt7cUjapQ1gL9Gv6WbHZ9jRwDFxAl0/d+VuuwwTBIi6+OcUN1zM c1DdroivWOk8I0f8wIe+BAdfmYaH9aR2gKLnNfRu7qHWs62TeFREYv9aIufIVLG5YNaO PRT3XrT68s8rvtfeukJ9x/EQUyfFQQ8NHVQMTtUBTxfTMZ7sgEE+ZEgfPDYqTpFRKwH7 5wulDuwh2+66dQfcxK/t3DNXMJb/HpYmolB9bxsCEYOSRRiCpzskhM3TFm0Oll/NEBkF eAGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=q8Vrto7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j5si10834070eds.204.2021.06.14.03.54.56; Mon, 14 Jun 2021 03:55:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=q8Vrto7Z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232898AbhFNKxR (ORCPT + 99 others); Mon, 14 Jun 2021 06:53:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:50444 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233876AbhFNKqU (ORCPT ); Mon, 14 Jun 2021 06:46:20 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1C30D61442; Mon, 14 Jun 2021 10:36:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623667001; bh=ui9gHbw+JDuf3P6B4ugtSGciC3XmmfsLRnx5lTFZ31U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=q8Vrto7ZcLFHv4UCa7Lwmhlu4S2eBrnflCnwyWF8fiJSOKE0Nd44YBj43rhYFUdj1 Kk1f2XNgbDJo5U/XBhDVr1vqsrYtD74Kah77pSXmubCSZuWawP9C3/zet44YwwHm1j QXWybzpdKFd6zl9PUWrq8lYLnf9khnnBZekyJ+sY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Paolo Bonzini Subject: [PATCH 4.19 59/67] kvm: fix previous commit for 32-bit builds Date: Mon, 14 Jun 2021 12:27:42 +0200 Message-Id: <20210614102645.760349043@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210614102643.797691914@linuxfoundation.org> References: <20210614102643.797691914@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Paolo Bonzini commit 4422829e8053068e0225e4d0ef42dc41ea7c9ef5 upstream. array_index_nospec does not work for uint64_t on 32-bit builds. However, the size of a memory slot must be less than 20 bits wide on those system, since the memory slot must fit in the user address space. So just store it in an unsigned long. Signed-off-by: Paolo Bonzini Signed-off-by: Greg Kroah-Hartman --- include/linux/kvm_host.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -1023,8 +1023,8 @@ __gfn_to_hva_memslot(struct kvm_memory_s * table walks, do not let the processor speculate loads outside * the guest's registered memslots. */ - unsigned long offset = array_index_nospec(gfn - slot->base_gfn, - slot->npages); + unsigned long offset = gfn - slot->base_gfn; + offset = array_index_nospec(offset, slot->npages); return slot->userspace_addr + offset * PAGE_SIZE; }