Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2649482pxj; Mon, 14 Jun 2021 04:02:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyTTbZn46YkCmT+3Kn68zzz+LiQGfGpzF/zPA9xC+ckfSwUW9zv8blTKTJvzwne/d4xc7l+ X-Received: by 2002:a05:6402:3586:: with SMTP id y6mr16123057edc.154.1623668541563; Mon, 14 Jun 2021 04:02:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623668541; cv=none; d=google.com; s=arc-20160816; b=Tcg6V2UCTM3nRN1wtZ7Uw7NMmp3VXSPWToMT2H19/Eaxh2pFCW2HVNqhlJ2TTZWIV5 ET7tsZpShXPVpafw65oxhGkW3PcHIgF9UfgRBY39NqOY59CnyVyZSFmG/jE3aSiFL45T mi1L8N6Z6ddQhgwcYy2fZew6b7KSaahxadqH3Sg5SzP8qJCsvV7cW3pfUCCXXNySjEGK rwbO6WmjfGQzCj6grojYvBzOHb4ZZ0W2NnRwkerct8hdcTnOVDaonE/h3v/YaG8qD9j3 +fdSgn52S4Glq21bs19SaeadxYRftg0bSn46lFW2Za5rJwHUtsh46Nx+lR5NtfuWdwBF kUTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=4buPh87fG82KGIPsqcStJkrrS32j1INrt7fwrwcFQ8g=; b=jbJMizYNGq6EuP3oxHWLm68s61/PMQEneo7vrUMBHjSrC466PuS1eyNRk9/5QfZ4Ep ZzCGdZcRlMDtcnX9tQCCLNxq1I/Ih6pOW4G+AE3dB233KPSQS+ES4YY1Dh3NcQxuWmGW ua+l6fjOCJZGNx3GpFa5JBZpHLIowaPN17I3BqUA/rIlZk51sxH3E3UBOj6QPpl9ZC1c q5GUS3Uq+vJnhiltUXcBz408QqUYWoh1pttXhYpPz/bAe40J7jJn7E88MO00hueZeK8+ 02cWwoSayXt4sPvoXYbxNXseDjcL6tCOXofaWKmvgEGG1qJWPtxOHVGksrmv0qI/9+HZ wvig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=em5Bf7cj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s27si11081813eja.413.2021.06.14.04.01.58; Mon, 14 Jun 2021 04:02:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=em5Bf7cj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235260AbhFNLAc (ORCPT + 99 others); Mon, 14 Jun 2021 07:00:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:58050 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234311AbhFNKw0 (ORCPT ); Mon, 14 Jun 2021 06:52:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 536FE6147F; Mon, 14 Jun 2021 10:39:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623667164; bh=HkXy/29+KCg0SHfbfQwmDgrjiU6bCvAaME+XJXMrYqI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=em5Bf7cjUuMkQ9sWhbkI7ZDlrWO0WFHNvaKHycQN1WPGCIZ5gx3PiMfAd/iK+FPSi CqOb0noVTw6kNBXcWdyRoOvDSuvTbkIsXyj6gfVU81jlpZh9a5m7OJ8perQWsBMuoh Eop2h7WOtVO5awPiCKJGQbtJYXc7wWA2mlxqLQKc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Saubhik Mukherjee , "David S. Miller" , Sasha Levin Subject: [PATCH 5.4 24/84] net: appletalk: cops: Fix data race in cops_probe1 Date: Mon, 14 Jun 2021 12:27:02 +0200 Message-Id: <20210614102647.178562986@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210614102646.341387537@linuxfoundation.org> References: <20210614102646.341387537@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Saubhik Mukherjee [ Upstream commit a4dd4fc6105e54393d637450a11d4cddb5fabc4f ] In cops_probe1(), there is a write to dev->base_addr after requesting an interrupt line and registering the interrupt handler cops_interrupt(). The handler might be called in parallel to handle an interrupt. cops_interrupt() tries to read dev->base_addr leading to a potential data race. So write to dev->base_addr before calling request_irq(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Saubhik Mukherjee Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/appletalk/cops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/appletalk/cops.c b/drivers/net/appletalk/cops.c index b3c63d2f16aa..5c89c2eff891 100644 --- a/drivers/net/appletalk/cops.c +++ b/drivers/net/appletalk/cops.c @@ -325,6 +325,8 @@ static int __init cops_probe1(struct net_device *dev, int ioaddr) break; } + dev->base_addr = ioaddr; + /* Reserve any actual interrupt. */ if (dev->irq) { retval = request_irq(dev->irq, cops_interrupt, 0, dev->name, dev); @@ -332,8 +334,6 @@ static int __init cops_probe1(struct net_device *dev, int ioaddr) goto err_out; } - dev->base_addr = ioaddr; - lp = netdev_priv(dev); spin_lock_init(&lp->lock); -- 2.30.2