Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2652984pxj; Mon, 14 Jun 2021 04:06:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwyGFUyGZ9CTztyC2AWtUQqNLtEM7UcKLmSJfQz5ncKUy119FxqtkBaGEk7kUYV3pxby0J9 X-Received: by 2002:a17:906:1c49:: with SMTP id l9mr14931634ejg.39.1623668806950; Mon, 14 Jun 2021 04:06:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623668806; cv=none; d=google.com; s=arc-20160816; b=tLO/7jTazgGU6Cq2fkswjGkN9O8MqkHnOtmI3umi2kg6IrRqiOL69Ae0GXhVfsO7yx v9xWCkvBmlOgeAe7YzfnUcfn99AcfcmChh6IrOR7KmTCebhxcWKqYmnWncHJiWRXGbM2 iZmVoJpgu8uRQe3XjFuQ48P9MdQidbqNhEnQx3nGD//H9Jy9fAu4jpWgsHnyEOAGWUTd W+vKcOcoLPoAid38Pg2lJGqFgAeYW/uDK2vpoei3xN9zimeo7sS2tYheGUAZRxQPVocD 88Dn4DKUvMsMnehzBP9cGLc5Iux4/k/pA4L+76NzfBSFxHN95i7Nteqc2JjKG6B6hOfx wNMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=fud0cYuqMmjtYNikgR/lRXiPToyL6Hbsb2RWGbKwP2Q=; b=FjrMeeRKchhZxeM4w1uBRzysmiFz3cjkEcCABin+ZRO+WENKcYNnALg0dez0eNS+pG oXAnQNUKvKZi0JdOrgXCyBSvaCM3edbLj6qY+4H7ymI/m2MK2cXgLPjbRHLzcE8YDgXY pX5SaYgCtKr7XqdoBrvWavSiGiVmOZ/2hR1HI4h4cHxDH7Z7vmC3AYIghZOdHsRQA48L wwLttlj3o5SV1iHPVY5i8BsB9+PzMX6wCMXa7T3B8xurKWUzRwcQgbpQybRaa8cBZFvI sF39NBlCBhVDAi8CoTibqco0noSWNXZ0MnxDWEdP6KY+gPyass2By+ZNtEzdSF+cc5oV Ikjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DT4MvtIo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u8si11280187edv.293.2021.06.14.04.06.24; Mon, 14 Jun 2021 04:06:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=DT4MvtIo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234575AbhFNLFi (ORCPT + 99 others); Mon, 14 Jun 2021 07:05:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:35246 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234127AbhFNK4P (ORCPT ); Mon, 14 Jun 2021 06:56:15 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67BDB615A0; Mon, 14 Jun 2021 10:41:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623667262; bh=Wb0yrOsNBITxibtbVHVNRT/x69LMKfbv31E2OITjUbE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DT4MvtIoB2hmO7ust3XsqD5y2KitAAUIU6ZmxTR+CjUTAeZ6q0+MEIF07R+1sXpE0 hvJwZKQwqfKIqG26HWHn5vtV7WtO4mBy2hbSCUfrZC4sezgtYsKC+H1kVV0yiCcQBF 5hUYOTiLaMDe6qdFpulmUqbEp+RZkPQsKjGIE9JU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dmitry Osipenko , Mark Brown Subject: [PATCH 5.4 63/84] regulator: max77620: Use device_set_of_node_from_dev() Date: Mon, 14 Jun 2021 12:27:41 +0200 Message-Id: <20210614102648.523245205@linuxfoundation.org> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20210614102646.341387537@linuxfoundation.org> References: <20210614102646.341387537@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Osipenko commit 6f55c5dd1118b3076d11d9cb17f5c5f4bc3a1162 upstream. The MAX77620 driver fails to re-probe on deferred probe because driver core tries to claim resources that are already claimed by the PINCTRL device. Use device_set_of_node_from_dev() helper which marks OF node as reused, skipping erroneous execution of pinctrl_bind_pins() for the PMIC device on the re-probe. Fixes: aea6cb99703e ("regulator: resolve supply after creating regulator") Signed-off-by: Dmitry Osipenko Link: https://lore.kernel.org/r/20210523224243.13219-2-digetx@gmail.com Signed-off-by: Mark Brown Signed-off-by: Greg Kroah-Hartman --- drivers/regulator/max77620-regulator.c | 7 +++++++ 1 file changed, 7 insertions(+) --- a/drivers/regulator/max77620-regulator.c +++ b/drivers/regulator/max77620-regulator.c @@ -814,6 +814,13 @@ static int max77620_regulator_probe(stru config.dev = dev; config.driver_data = pmic; + /* + * Set of_node_reuse flag to prevent driver core from attempting to + * claim any pinmux resources already claimed by the parent device. + * Otherwise PMIC driver will fail to re-probe. + */ + device_set_of_node_from_dev(&pdev->dev, pdev->dev.parent); + for (id = 0; id < MAX77620_NUM_REGS; id++) { struct regulator_dev *rdev; struct regulator_desc *rdesc;