Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2677096pxj; Mon, 14 Jun 2021 04:44:23 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy2G3wZ7gKNFADdXzUSL5T+9D3GrHEnjibUsTvk2TRg0IcXpwvj/tdN8dpVQxWmTN+eCirQ X-Received: by 2002:aa7:c753:: with SMTP id c19mr16531308eds.33.1623671063351; Mon, 14 Jun 2021 04:44:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623671063; cv=none; d=google.com; s=arc-20160816; b=oIZr2G1f75Daqe56da9DeDe8gGK5PKySox1Cy6WBaK3zK0RnKkw9Pxpa0bkRqaCmmt V7BITs5co89+AQ++DsV/VdCwFa86/mMJ6cRrBEjSi+N4wo9pT04UxyHonUsUTn2I0E4N E0oJW02fmcla6na+jZQg3PS2OXmOJvfJwsORk4qW4v8UtxasoWzJqLG8f3Cwh4ZUeevE PTNB6UW2JfrOtreUBvdi99znp9I5PJ6bziswFChLhUi8Kno1NETvRv0wYetIpWceRLA0 HjIdLWuCcCYoXmhwsiLVwEoGr6jSlb8ySE68Xz2YP+WXLe6hfNnV2HOXtJ+mrqLODcTi r3jA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:message-id:references:in-reply-to :subject:cc:to:from:date:content-transfer-encoding:mime-version :sender:dkim-signature; bh=hzwIJOQ7OctpDsRQNZTjjMstVXO6J3lo7iM4zpxApOA=; b=LYkvq2eA0DOvYw6hLvvdh+nH11rbyhon+2dmNE3FndAMXR9ggHAzNYehiWTiTnxQaH aXnQfNIK4pMiJiqtNeMADKmldOpvtNxEmIvDJgVsvirEW6BO2F47Mj5ytiaXsv7nK10A 3ykHhXNAF2FBCkTmvbXpiM1P3KU6mkEOO0EZZ6BmsTOwp6pHvwYn8JtUVAtz4KNGD8xr 4mPqv2hIfkSsLjKvyyxv47HUq4gl+Q1mqoL0ZPGdWS8Y1jtDm2OSqVrdw0h+5GxwvTdF z/DOeVU+xV9q0XwpfWVIROr//o1A+rPHXiSD2nvCQSP8wul/Axkb08YIHPTQqQsgEnTk QIcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=SJU6sj1s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q1si11652378ejy.298.2021.06.14.04.44.00; Mon, 14 Jun 2021 04:44:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=SJU6sj1s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236810AbhFNLoV (ORCPT + 99 others); Mon, 14 Jun 2021 07:44:21 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:43520 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236907AbhFNLkP (ORCPT ); Mon, 14 Jun 2021 07:40:15 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623670692; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=hzwIJOQ7OctpDsRQNZTjjMstVXO6J3lo7iM4zpxApOA=; b=SJU6sj1smsJ7tMeCo/Cte64ZdWe64hGTgrBamrRYYGyUOmtbbTx5BCQ31+U+e8+l/J1Fg2mX pCTrMLPdh4e5nVj1H7ZgSWE2OiG9dyQrecWFtTMZinuepCx7dBD0MoBoYp3OdgP6mKPXe6zv U0IlXdXdPnxH/4xBm4j2EtiiL9E= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-east-1.postgun.com with SMTP id 60c73f90e27c0cc77f961471 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 14 Jun 2021 11:37:52 GMT Sender: sbhanu=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6EA31C43217; Mon, 14 Jun 2021 11:37:50 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sbhanu) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3CD92C433D3; Mon, 14 Jun 2021 11:37:48 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 14 Jun 2021 17:07:47 +0530 From: sbhanu@codeaurora.org To: Georgi Djakov Cc: adrian.hunter@intel.com, ulf.hansson@linaro.org, robh+dt@kernel.org, asutoshd@codeaurora.org, stummala@codeaurora.org, vbadigan@codeaurora.org, rampraka@codeaurora.org, sayalil@codeaurora.org, sartgarg@codeaurora.org, rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org, sibis@codeaurora.org, okukatla@codeaurora.org, cang@codeaurora.org, pragalla@codeaurora.org, nitirawa@codeaurora.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, bjorn.andersson@linaro.org Subject: Re: [PATCH V1] arm64: dts: qcom: sc7180: bus votes for eMMC and SD card In-Reply-To: References: <1623309189-27943-1-git-send-email-sbhanu@codeaurora.org> Message-ID: X-Sender: sbhanu@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-06-10 13:04, Georgi Djakov wrote: > Hi Sajida, > > Thank you for the patch! > > On 10.06.21 10:13, Shaik Sajida Bhanu wrote: >> Updated bus votes for eMMC and Sd card. > > The commit text should also give answer to the question "Why is this > patch necessary?". Do we need a Fixes: tag? The subject could be > improved too. Please check: > https://www.kernel.org/doc/Documentation/process/submitting-patches.rst > > Thanks, > Georgi > Sure will update the commit message >> >> Signed-off-by: Shaik Sajida Bhanu >> --- >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 20 ++++++++++---------- >> 1 file changed, 10 insertions(+), 10 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index 295844e..1fce39d 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -726,15 +726,15 @@ >> opp-100000000 { >> opp-hz = /bits/ 64 <100000000>; >> required-opps = <&rpmhpd_opp_low_svs>; >> - opp-peak-kBps = <100000 100000>; >> - opp-avg-kBps = <100000 50000>; >> + opp-peak-kBps = <1800000 600000>; >> + opp-avg-kBps = <100000 0>; >> }; >> opp-384000000 { >> opp-hz = /bits/ 64 <384000000>; >> - required-opps = <&rpmhpd_opp_svs_l1>; >> - opp-peak-kBps = <600000 900000>; >> - opp-avg-kBps = <261438 300000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + opp-peak-kBps = <5400000 1600000>; >> + opp-avg-kBps = <390000 0>; >> }; >> }; >> }; >> @@ -2685,15 +2685,15 @@ >> opp-100000000 { >> opp-hz = /bits/ 64 <100000000>; >> required-opps = <&rpmhpd_opp_low_svs>; >> - opp-peak-kBps = <160000 100000>; >> - opp-avg-kBps = <80000 50000>; >> + opp-peak-kBps = <1800000 600000>; >> + opp-avg-kBps = <100000 0>; >> }; >> opp-202000000 { >> opp-hz = /bits/ 64 <202000000>; >> - required-opps = <&rpmhpd_opp_svs_l1>; >> - opp-peak-kBps = <200000 120000>; >> - opp-avg-kBps = <100000 60000>; >> + required-opps = <&rpmhpd_opp_nom>; >> + opp-peak-kBps = <5400000 1600000>; >> + opp-avg-kBps = <200000 0>; >> }; >> }; >> }; >>