Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: I/MjTrOgRPoRqLrrqh6u0OLgZKOhfQaBw9I3aVYXZqrLStocL7CGgzSkiyRbmNH9d3WZDCPMrd
 p4YdVwl5c+5i48yEXeS2WlIJLdI2ciQfbHzgdGbAGgCk/09eMM9VkZ/ZMHoenbnU9zWG3mfTZb
 PfaODEvSNzYBWd61bvWYuKoRvPecoSkWrZBXysjxFfEAv22z38lLuJBUBufGMT8SvZPN2D37jT
 QRd+FfnyZ1LINBkF1h0nvBJYnrtZsjQEsVUlFI1fOaAvNeask2IAHZuWUzdBbWbwaQTo57jCd3
 050=
From:   Niklas Cassel <Niklas.Cassel@wdc.com>
To:     Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Damien Le Moal <Damien.LeMoal@wdc.com>,
        Shaun Tancheff <shaun@tancheff.com>
CC:     Damien Le Moal <Damien.LeMoal@wdc.com>,
        Niklas Cassel <Niklas.Cassel@wdc.com>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>,
        Jens Axboe <axboe@fb.com>,
        "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [PATCH v3 2/2] blk-zoned: allow BLKREPORTZONE without CAP_SYS_ADMIN
Thread-Topic: [PATCH v3 2/2] blk-zoned: allow BLKREPORTZONE without
 CAP_SYS_ADMIN
Thread-Index: AQHXYRgQCVfFQ7HNWEWEcKzi48L9sg==
Date:   Mon, 14 Jun 2021 12:23:21 +0000
Message-ID: <20210614122303.154378-3-Niklas.Cassel@wdc.com>
References: <20210614122303.154378-1-Niklas.Cassel@wdc.com>
In-Reply-To: <20210614122303.154378-1-Niklas.Cassel@wdc.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?R6+0rohg4+EOoAid6yIhSIVdejHd/9R6CsMWC3ZcP4BspyqpHZmn9aPajJ?=
 =?iso-8859-1?Q?RHcEIW0nsafeLqRAkjKWHSy+duTqCtamCsSt2XF0S1PCkEXi7RW7ufDVuv?=
 =?iso-8859-1?Q?/8AP/MeAisNXAO6DgKMGGTGiqxGPyHfvySaTT5SZ1nS7JxtP2X+GG9H7nQ?=
 =?iso-8859-1?Q?yx8QAw4xjrli8ORZQ/djTRjkt5EzVW8lU9+BTg+MvQqcuv2YFIv1iM9JuH?=
 =?iso-8859-1?Q?ajrjP5Zwwxr/XF6d1SwBGOmfGKgRPhexrsgwkIDcg6U+unsfORSYrnl6l7?=
 =?iso-8859-1?Q?/XIq9j898HT4fRrMn1dHKJydyhaoEsuXhEz7KYVUBRupIR2ic3jc+cXIAG?=
 =?iso-8859-1?Q?G0fbGR1e8aIc8TkX8souZsNcFY8v2avmWb7HwVW0jOrxabEZQja9vqGsFJ?=
 =?iso-8859-1?Q?mexx2HwG8VKQ/V+T+60Cq6SoquoHhQV5oPCWeD5vLsui6fQGybtbLZ7oYF?=
 =?iso-8859-1?Q?mrJ0t7gGqLbx8/6bHq3iKxrnavoCldMQMdAjiZP1087UviFV27m9YiNZZV?=
 =?iso-8859-1?Q?gVYcI8EiJPSo80aC9AUbiNmq6ieahWSO6RG886w/RlsWxLF7nVTN9AhLY7?=
 =?iso-8859-1?Q?56yiBydEgLYO2Dyz/0lJaSM84EAucPqJGaGi05C20JkfRBrqY2mOg5BhFg?=
 =?iso-8859-1?Q?/OOQmqR6PDakfkkpx/TwGt/D611fLuPB5s/z7ASibV6KveoznOOuu/Lc4M?=
 =?iso-8859-1?Q?z922HfxVNaaveaiKHd5pyeTUXG7NHrOkaHUEVF5RDm6djUlkHFOrumKvVP?=
 =?iso-8859-1?Q?kc20WRRq3OmQwCMDBgdD8ezPCXlUpHe48xHXKy4WFA/NQqdyYWBGHoXZF6?=
 =?iso-8859-1?Q?gsV04vQcAzlNERm30/X4QwAHpK/tMo5MQn6EscUJ5KY8ppIR/xYDxu8Az8?=
 =?iso-8859-1?Q?vfNHoDJkwq+fKGe8Q50BK5N4E200RayXXAJqxxySQkyyY3Fh3zH0Cv7AHr?=
 =?iso-8859-1?Q?6blrf0q+6rlRvgjfuPwlnPfNdBI87M+BvSis4Ujv59A0OfbyHlo9ZBN5Kc?=
 =?iso-8859-1?Q?Yh3BWi6KPHcdHnij4ME7dvRnxceksufiUvVyeeqpNLyOYZEdWf6fQjflR7?=
 =?iso-8859-1?Q?qaZZVylSNFHgYINMj/Qu5+zx3tVh7RV4uOJAl2L+/788thZlTtIc+VxGJf?=
 =?iso-8859-1?Q?c79gOQu0mNyp203wnDK87eiO0aEMAPJ9l9oGW2T4u4BCJD73NcvlryPDqd?=
 =?iso-8859-1?Q?zVOlnQLG06GD22E3F8I3BrN8djp+iaUVP4WAoxQeeHqv0gRS9Zg0yBU9aJ?=
 =?iso-8859-1?Q?WuFIQ2VcIhqthz9fMDEPWtfh2HJKARpinAQF1GRypc+trr4am5e1QlzA5E?=
 =?iso-8859-1?Q?HthkWUQwSaCZNNo+FHj+ea5t80FjqPRk2C0PxZXF/v2RLHq7T7928u82Hm?=
 =?iso-8859-1?Q?hRJczaTmSd?=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PH0PR04MB7158.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66bb170c-19cb-4a17-ae1f-08d92f2f34b1
X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jun 2021 12:23:21.7957
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ayHpFmtRVV1qBgjv7MOe9ZcMHY0FfX/vsdKE5AEQ/hnjKkdTAGsWR8VHEMHEwYzWHzTRanVNio+PsDPh6l+yrw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR04MB7365
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Niklas Cassel <niklas.cassel@wdc.com>

A user space process should not need the CAP_SYS_ADMIN capability set
in order to perform a BLKREPORTZONE ioctl.

Getting the zone report is required in order to get the write pointer.
Neither read() nor write() requires CAP_SYS_ADMIN, so it is reasonable
that a user space process that can read/write from/to the device, also
can get the write pointer. (Since e.g. writes have to be at the write
pointer.)

Fixes: 3ed05a987e0f ("blk-zoned: implement ioctls")
Signed-off-by: Niklas Cassel <niklas.cassel@wdc.com>
Cc: stable@vger.kernel.org # v4.10+
---
Changes since v2:
-Drop the FMODE_READ check. Right now it is possible to open() the device w=
ith
O_WRONLY and get the zone report from that fd. Therefore adding a FMODE_REA=
D
check on BLKREPORTZONE would break existing applications. Instead, just rem=
ove
the existing CAP_SYS_ADMIN check.

 block/blk-zoned.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/block/blk-zoned.c b/block/blk-zoned.c
index 0789e6e9f7db..457eceabed2e 100644
--- a/block/blk-zoned.c
+++ b/block/blk-zoned.c
@@ -288,9 +288,6 @@ int blkdev_report_zones_ioctl(struct block_device *bdev=
, fmode_t mode,
 	if (!blk_queue_is_zoned(q))
 		return -ENOTTY;
=20
-	if (!capable(CAP_SYS_ADMIN))
-		return -EACCES;
-
 	if (copy_from_user(&rep, argp, sizeof(struct blk_zone_report)))
 		return -EFAULT;
=20
--=20
2.31.1