Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2712911pxj; Mon, 14 Jun 2021 05:34:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz1w83y+KdPX1fLXdJ+KVQAT5ZOXKJCBa93bTFvwLfje6RyKUCs1REt0LmbqTSAjnTopVE0 X-Received: by 2002:a05:6402:b1a:: with SMTP id bm26mr16990997edb.387.1623674082862; Mon, 14 Jun 2021 05:34:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623674082; cv=none; d=google.com; s=arc-20160816; b=bpxP/w+kcb8l35SqJl2eNO789rZohh6ODmyVkvbohV0qWnO7OXu8TedMwTMFs8jll2 3gXDcawXB6tKcEJ1yh4ANwV2k/W8sNGk8P+xjZk5C2khaw2O/3ojcUKtFA1LIXAoKlfI M2eiZTnU+7BUIq7Ggb9gebyYwRIaBYWLlo1m8AbiWwCILLf7rrxPqvEYahWKFZn79Ace N5DRdC6L7pQdO3UBwlU4IE7nYQhFGxgu6woqdOLMYf1GqvX3VCriNfHwBC+ADQy3ly3R xZv2RjqviAX9w9TXHTX8hR56qMa+rMo82ssBr6NiQzj6gZ+6M/C9Ffp4/f4JGZnsWyu5 tk9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ZZKvIEpsaGYUMFQ3fgpTkT5VsdH4goR4WcL96t1S438=; b=S9TtipS5GuDAxNeFdR0rf8Ggrl/W7Ntoh8Pj91ru7QwD0rDPWi84Gb6d845HxZcdh4 ibDh4dBHGV5G01aOKTaQ1D0/heUiTaMvwEr8BVvG471qN3rGNrRcPkH87gbzOB7nb2NK lpGWLAvfhJmwmhN9LA6Gzo687lDXcQf/8/C588LD1i5LxtMmGVrMO1Hq/CoIyZLJBsZE 1jV/MhgY7p4aeDQOPLFG87xSrlOEBn8ZK/VEnKHZt1ogVcpVVwJiUT8zwlkogYsLwAZZ tfaA/tfiBhUezaTGySVj4tguj0EIdjcV6tFSOPvSuiPW+/3BEHOraqAt4w1IhRP4FAm3 V9BA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ORVU0RUB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g12si11111886ejd.330.2021.06.14.05.34.19; Mon, 14 Jun 2021 05:34:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=ORVU0RUB; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233393AbhFNMfM (ORCPT + 99 others); Mon, 14 Jun 2021 08:35:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233218AbhFNMfL (ORCPT ); Mon, 14 Jun 2021 08:35:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98DCDC061574; Mon, 14 Jun 2021 05:33:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZZKvIEpsaGYUMFQ3fgpTkT5VsdH4goR4WcL96t1S438=; b=ORVU0RUBdzzZwfhSwmynH8ckhU rpBKtHq7boJ9Nileky+klBSkC8A6BeUJXRzslqfq6khT0wWC4mqzz+aZmUVfCD6lIytp1KmIPNex9 Nc7iyDeoiQY5TzwTMydnzxSImGI6Xq2ghn1vXxJDPMk7avO2vVIx8jdH4U6+pRjzXlmpcTRfvhvG6 LM4A85lnby3/xwY1LSuXpXGenWYd/6+2UdBJHfKMkLOCh5d/XB97Kx4I1y8/Q0CorvK513Obz2CLs Pawgn7oeabJGnzOzSonuhqvXdqLbySUAudKGBF2Z6SBV382kjUPkn2ZLvaq+G5jQBFTzkE4q3Xl+k nJd7c/vg==; Received: from willy by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lslli-005Pl9-28; Mon, 14 Jun 2021 12:32:44 +0000 Date: Mon, 14 Jun 2021 13:32:42 +0100 From: Matthew Wilcox To: Christoph Hellwig Cc: Andrew Morton , Jan Kara , Al Viro , Greg Kroah-Hartman , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] fs: unexport __set_page_dirty Message-ID: References: <20210614061512.3966143-1-hch@lst.de> <20210614061512.3966143-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614061512.3966143-2-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 08:15:10AM +0200, Christoph Hellwig wrote: > __set_page_dirty is only used by built-in code. > > Signed-off-by: Christoph Hellwig Reviewed-by: Matthew Wilcox (Oracle) You might also want to do the equivalent of this: https://git.infradead.org/users/willy/pagecache.git/commitdiff/19b3bf0d1a51f41ce5450fdd863969c3d32dfe12