Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2736213pxj; Mon, 14 Jun 2021 06:07:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJymn+dfhBTn/1j/qANK6fALVUm6VMHSaYw5O0bRegMS7XRTmbj2wOB/pueDwfBB4w4VwJ/n X-Received: by 2002:a17:906:7302:: with SMTP id di2mr14940157ejc.409.1623676039540; Mon, 14 Jun 2021 06:07:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623676039; cv=none; d=google.com; s=arc-20160816; b=JCycfpbTYmpkp9+DOpyjuwwAvPJxVr1/46I6w7IFuqnYHWlD+SP+ClD5zTAPPhM+4e pRmX7hDLKEPUdq4z/a1LzQb4HocaUnWW0iB4Kmq/Zgco1Bw28gscPaFURHIlilZAf4DR Mt85aOYTKbi50IIxhJ6msDvXORPVO9vQnjshgbPwHod/Wp5YhkpjrQIzCGd39B9V6sAV sjii6BhcL44QLWkkGzWHYRomMLejQ+6sQCCIQUlzUHYwND4SxyxO2bErxAFLHjrbXPan ffSk7wEAPsE4xAuEEyBXjiiIoGZn/Ocd9BV4St+sh0BC7bk1jaUOQw40W8PffU2mcGTU qMtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=JLgmK5I1EDeVcLPrVJ/cchXYy85jWd9YhXL/o+rzgAA=; b=fS6RXwhrMAevX05k8VuHb6HmU//4aqZn4Ha0hzabZoq0LNNwvDXgXk4WKfE23QaepS 2YQ0lgiK0gpouNBo0BbVbnny+pWWFPMshVIwOzlb6LEbH7W9flbqHXJG139qLuGMELJq pRLL/IB4SWpJ4hwUXWU8uYEbDifKmGdBtDlMiN2Oqlp1URaU9CHIb8WZVyYWjrvqhX+u QlKQropZxZEJ3vFO/IE1J43ps4sKXSUDgiOyIbn9bSaq+APnP874xezHZ2+M0j7GuTHI pPYxA9MlCHXQOmrJg73MYwdVL7PgI83xHMgxQCVPIvQ1QE+45yWsosYl5DRXUpT6xNd+ H2uA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j4si5189772ejj.545.2021.06.14.06.06.55; Mon, 14 Jun 2021 06:07:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233575AbhFNNG2 (ORCPT + 99 others); Mon, 14 Jun 2021 09:06:28 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:6469 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233226AbhFNNG0 (ORCPT ); Mon, 14 Jun 2021 09:06:26 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.53]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4G3WmS1kJXzZh5N; Mon, 14 Jun 2021 21:01:28 +0800 (CST) Received: from dggemi759-chm.china.huawei.com (10.1.198.145) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.2176.2; Mon, 14 Jun 2021 21:04:19 +0800 Received: from [10.67.102.67] (10.67.102.67) by dggemi759-chm.china.huawei.com (10.1.198.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 21:04:18 +0800 Subject: Re: [PATCH V2 net-next 00/11] net: z85230: clean up some code style issues To: , , , , CC: , , References: <1623670131-49973-1-git-send-email-huangguangbin2@huawei.com> From: "huangguangbin (A)" Message-ID: <17dc444e-2a28-eaf0-7426-30bf9e6f2825@huawei.com> Date: Mon, 14 Jun 2021 21:04:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <1623670131-49973-1-git-send-email-huangguangbin2@huawei.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.102.67] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To dggemi759-chm.china.huawei.com (10.1.198.145) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/6/14 19:28, Guangbin Huang wrote: > From: Peng Li > > This patchset clean up some code style issues. > > > --- > Change Log: > V1 -> V2: > 1, fix the comments from Andrew, add commit message to [patch 04/11] > about remove volatile. > --- > > Peng Li (11): > net: z85230: remove redundant blank lines > net: z85230: add blank line after declarations > net: z85230: fix the code style issue about EXPORT_SYMBOL(foo) > net: z85230: remove redundant initialization for statics > net: z85230: replace comparison to NULL with "!skb" > net: z85230: fix the comments style issue > net: z85230: fix the code style issue about "if..else.." > net: z85230: remove trailing whitespaces > net: z85230: add some required spaces > net: z85230: fix the code style issue about open brace { > net: z85230: remove unnecessary out of memory message > > drivers/net/wan/z85230.c | 995 ++++++++++++++++++++--------------------------- > 1 file changed, 423 insertions(+), 572 deletions(-) > Please ignore this series, there is new comment has not been dealt with.