Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 RESEND] ata: ahci_sunxi: Disable DIPM
To:     Timo Sigurdsson <public_timo.s@silentcreek.de>, mripard@kernel.org,
        wens@csie.org, jernej.skrabec@siol.net, linux-ide@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev,
        linux-kernel@vger.kernel.org
Cc:     sergei.shtylyov@gmail.com, gregkh@linuxfoundation.org,
        oliver@schinagl.nl
References: <20210614072539.3307-1-public_timo.s@silentcreek.de>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <4c873409-db09-31ea-485e-daa0433c674b@kernel.dk>
Date:   Mon, 14 Jun 2021 08:27:04 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20210614072539.3307-1-public_timo.s@silentcreek.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/14/21 1:25 AM, Timo Sigurdsson wrote:
> DIPM is unsupported or broken on sunxi. Trying to enable the power
> management policy med_power_with_dipm on an Allwinner A20 SoC based board
> leads to immediate I/O errors and the attached SATA disk disappears from
> the /dev filesystem. A reset (power cycle) is required to make the SATA
> controller or disk work again. The A10 and A20 SoC data sheets and manuals
> don't mention DIPM at all [1], so it's fair to assume that it's simply not
> supported. But even if it was, it should be considered broken and best be
> disabled in the ahci_sunxi driver.

Applied, thanks.

-- 
Jens Axboe