Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2845104pxj; Mon, 14 Jun 2021 08:26:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw4O7WNeDyturLRouuLIsey8eqGjfXitH0hXQmHHYV4CJkXJuxOfKQy2wwwNYWS5xipgIzl X-Received: by 2002:aa7:ce86:: with SMTP id y6mr17678584edv.309.1623684372616; Mon, 14 Jun 2021 08:26:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623684372; cv=none; d=google.com; s=arc-20160816; b=RC7J2gIvTFSwoBmyIGzSUnlbWRlj5v4VMNPZHcwQU7FVqnbpxQa+tJlEGhsH0SRH0H b9O+vDn+KEybe4vGb0gRJcvfO0vLN4OHa6pVrJanPe5bo+kcMM/WdXkEX57l6U3WaUFX 6LJXTJnw2gBZR1jSaNqvQVIGxgd7uBxVzJBB6Z8aC1ykMAAUvaiDgUQdtXWIC02T0kr1 nMRlTSjz++kC73U8dA4tCyhSIg2y5P16moesxqgl9i2UW6/5TiaVlI697ciHG3FJkBXR N4fix0dk6lOkrLHHdZKEGIRdTh+MVAk/XON1kdUH0elFdljLkSVHUEZ1r1fhqQnCzCbF 336g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=j1qkA0UBRXmvTXxhVjG/l5z+lefptA704EV3PoN5jFk=; b=F/kk1K+r5UZRWRFXxUKa2/qSNP6L7moiYwQBt1K6abhuEvS40N56U/WcMGIWx1LQnD hAcSjycmxYkvRM0fTGkLpOyiB2jJuVh5Vfbn9Fn7V7F/A2ALWNuqEeNoYX7/LFQUmTQP UpOJgy0UMjxQCEttDozYyzXhyTbSkhjxwiBkWZeJToacQ2R2wtcXIRcSRcMhcnoZ7B5b uuJUGNFpcULc+q2m7a+8NFTGtmp9BS4Dg19H8uz2FtCyJMlZ3eNM3Ydg9K9TojRoJbo4 py9iWx8DWQexQuoJIb5TkozXbbRfqB77/vP5RqIGz1tR2mEBr8Os1E3GojDRw0rsDj97 yazQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="IFif+/oe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si11869763ejc.505.2021.06.14.08.25.49; Mon, 14 Jun 2021 08:26:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b="IFif+/oe"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233492AbhFNPYQ (ORCPT + 99 others); Mon, 14 Jun 2021 11:24:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233387AbhFNPYP (ORCPT ); Mon, 14 Jun 2021 11:24:15 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BBC43C061574; Mon, 14 Jun 2021 08:22:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=j1qkA0UBRXmvTXxhVjG/l5z+lefptA704EV3PoN5jFk=; b=IFif+/oeJCeFESO9YTRGsltVL2 i3QUP5oCRIxlWMygISDjFMuE7BECa725GGCbCMX2+ArTR+SbiNGEX3Fd3KXX+/FEvGSynNSlnUZWi UAtIWYj5vLgnhfCCf39nZn8Fz4X1MI5JTGJ/5RsHGA3k33v3w7y9+rmUpJGYFlzknIjntDhrT26Bt WUx0rCPE4MyDFJaC+CoeX1cSkFkLfRQYbsBWLucbgEL2UAmouFyaffB0/ueYb2AtEZKX6aV9hR8aD /5V3sdwAWzxIsTUjLw1XJh6Ofwdp8r1jnrETyXKkqlwToPgIloSXHB4/tPU6yMG5PW9Rt+u3wJ9fz LANxu78g==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lsoP5-005YXM-9W; Mon, 14 Jun 2021 15:21:45 +0000 Date: Mon, 14 Jun 2021 16:21:31 +0100 From: Christoph Hellwig To: Claudio Imbrenda Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, frankja@linux.ibm.com, borntraeger@de.ibm.com, cohuck@redhat.com, david@redhat.com, linux-mm@kvack.org, Uladzislau Rezki , Nicholas Piggin , Andrew Morton , Catalin Marinas , Thomas Gleixner , Ingo Molnar , David Rientjes , Christoph Hellwig Subject: Re: [PATCH v4 1/2] mm/vmalloc: add vmalloc_no_huge Message-ID: References: <20210614132357.10202-1-imbrenda@linux.ibm.com> <20210614132357.10202-2-imbrenda@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210614132357.10202-2-imbrenda@linux.ibm.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 03:23:56PM +0200, Claudio Imbrenda wrote: > +void *vmalloc_no_huge(unsigned long size) > +{ > + return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL, > + VM_NO_HUGE_VMAP, NUMA_NO_NODE, __builtin_return_address(0)); Please avoid the overly long lines in favor of something actually human-readable like: return __vmalloc_node_range(size, 1, VMALLOC_START, VMALLOC_END, GFP_KERNEL, PAGE_KERNEL, VM_NO_HUGE_VMAP, NUMA_NO_NODE, __builtin_return_address(0));