Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2849435pxj; Mon, 14 Jun 2021 08:31:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxVeC09QOV0SQyPOcAanK/7zFPLvbJfWVleNs3T9d7tWhuwE/EkMiyEgootGklZhQUxmN4T X-Received: by 2002:a17:907:2156:: with SMTP id rk22mr15599022ejb.464.1623684718180; Mon, 14 Jun 2021 08:31:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623684718; cv=none; d=google.com; s=arc-20160816; b=YpFNtFMoAA1yKIYLC1Z9U5+nmmycjQlLoS4CEuvEDnmkjwjc3WRFTDg7N4snsU7j6W O980aiSUwjM3tGrRr+v5Sp8czm9gJZyRBHj7btTz71URl0qolMIG4tC2iyAqAc7mMObC 5Tbn2/KjVi5jKmPaH2LK1tONHT+XnKs2BzV19Wa6VrLpBM+gWgVkNLNZ6wq24M0Ona6S DAGLBTryb+SM4T55quPOjxu4lfwTNo95CaJIvLGaGWRgVlvUvaGrcWkFXGQT1ibABAbs pCjcGbW5h2zFoy2Cg+3IQHCt0g8cOehDn/z2s0hZxIGEJ8W6ZuX9FiRTKvc/zH6ez9Nj feRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=BOAPjwbtdUFJhW0vGZOZuptTrlFMtA9QPhXUlP40eQY=; b=YptYOYMDt4X6xo14ZBiC8rLE5QQjf+9yNmG4BQeeLXRA4s9eiAdZhAdUl5OsDAL0YG lxNuNKmF5frv1moKHrx5dnTAtcdL75D2jqktg7n/gpCJA4ZggB6f8Bm79J+cSLBzGYQm FsPo8IgefbGY5s4t0lIXrrmX5hWjrD7NGGRRNx9185ECk5CI4PQF4i8mbJ92ZFme2Bzv 8iErcPvAKxX9EnD4MEu3yd490zuRJdApUVfNel3l6lVzl7ZgDPAYF5zMKoKa9L3hDAp5 vgbfEEoIM7sJJ1qx8eJux5QRBvfPOVSi+s3Z7iJVE5YFwEKWrRDIBmV1eBJ6gM6v696B PQ1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XkpzfRqm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i24si12529268ejx.167.2021.06.14.08.31.35; Mon, 14 Jun 2021 08:31:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=XkpzfRqm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233825AbhFNPcq (ORCPT + 99 others); Mon, 14 Jun 2021 11:32:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234031AbhFNPcU (ORCPT ); Mon, 14 Jun 2021 11:32:20 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 73BC6C061787; Mon, 14 Jun 2021 08:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=BOAPjwbtdUFJhW0vGZOZuptTrlFMtA9QPhXUlP40eQY=; b=XkpzfRqmBRHXIKnme9t/VjQIKy Zat1XtfRe8V7UJlt6lovmkDrp/eMfRPtb/+QgqmUj125U4i8ZvOeY1iGnrFE0srCupfWZ0n+xDQ8f c0aKSmY8opAMCTNDU0GFm6gD8PpZz62ETmtzFsX6e3QXGaVa1D0MmK7Jc1DXHtK5ANiaSEzNekGWp 2xKx51/J7g0W27PgOqsE1IGKK158UN2CyOQuzGDjN7PBTMA0DmqpO62efsKOg9YXc0xG6mLQ80Yiv c0u4GkVlSZLub+dEctSHP+a2CRKM4X+iyw5zU/gx7THbI5bfNERC+C+HGdEYoj1jDqmAcCfvMZkLf 3PtQfg0Q==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lsoUv-005YqL-2Y; Mon, 14 Jun 2021 15:27:47 +0000 Date: Mon, 14 Jun 2021 16:27:33 +0100 From: Christoph Hellwig To: Max Gurtovoy Cc: Christoph Hellwig , Alex Williamson , Jason Gunthorpe , cohuck@redhat.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, aviadye@nvidia.com, oren@nvidia.com, shahafs@nvidia.com, parav@nvidia.com, artemp@nvidia.com, kwankhede@nvidia.com, ACurrid@nvidia.com, cjia@nvidia.com, yishaih@nvidia.com, kevin.tian@intel.com, targupta@nvidia.com, shameerali.kolothum.thodi@huawei.com, liulongfang@huawei.com, yan.y.zhao@intel.com Subject: Re: [PATCH 09/11] PCI: add matching checks for driver_override binding Message-ID: References: <20210603160809.15845-1-mgurtovoy@nvidia.com> <20210603160809.15845-10-mgurtovoy@nvidia.com> <20210608152643.2d3400c1.alex.williamson@redhat.com> <20210608224517.GQ1002214@nvidia.com> <20210608192711.4956cda2.alex.williamson@redhat.com> <117a5e68-d16e-c146-6d37-fcbfe49cb4f8@nvidia.com> <1f7ad5bc-5297-6ddd-9539-a2439f3314fa@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1f7ad5bc-5297-6ddd-9539-a2439f3314fa@nvidia.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 11:18:32AM +0300, Max Gurtovoy wrote: > * into a static list of equivalent device types, > * instead of using it as a pointer. > + * @flags: PCI flags of the driver. Bitmap of pci_id_flags enum. > */ > struct pci_device_id { > __u32 vendor, device; /* Vendor and device ID or PCI_ANY_ID*/ > __u32 subvendor, subdevice; /* Subsystem ID's or PCI_ANY_ID */ > __u32 class, class_mask; /* (class,subclass,prog-if) triplet */ > kernel_ulong_t driver_data; /* Data private to the driver */ > + __u32 flags; > }; Isn't struct pci_device_id a userspace ABI due to MODULE_DEVICE_TABLE()?