Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2852895pxj; Mon, 14 Jun 2021 08:36:30 -0700 (PDT) X-Google-Smtp-Source: ABdhPJypuMUoWp69/lWEg3Lv6JeT8U95OTd4nwqppTgIi5iNNV0OkLwnjoJaTODjf5cQQgUqZihv X-Received: by 2002:a17:907:f9b:: with SMTP id kb27mr16061729ejc.44.1623684990588; Mon, 14 Jun 2021 08:36:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1623684990; cv=none; d=google.com; s=arc-20160816; b=RsvugCc57rMhFzZTLVR24Hs8nERMUxnkvxK+dZx5E63TM/suwSgi8QsF7e1RGafv7L bdg3ELNvoDwn+wpyVmsbwW6oSwWlCY3Eys/3yH1qsLi/B9weAZjRwMxkUZ1iLcjVvqKb kQUxnfZybODBSyFnfw386nVe66tDBAvvBiBm9ayi6rNLxst1+F1HDOktUhGcyaFptPPS Dvbg7/cG5+dQhAXdsXx773D+/KzFu7JNpYnwtLaQ/6TCSkVLJWZZaANLOomxxE1l9ckr /esj8R9NZgB+HqDeMut6D59h3XaPW343HV5Dy/Fn7xn3Y+XKW1i/3OcMOTehrrFCc0ou I2ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=eFs4pbQ7ykTzIyK6l05Qc65QjKj34HgsxqextmeFnlc=; b=pUqiDrvpvxO298mPd98qsYe+c23KLMUpA43VBLvGjLsDMgnMDRT1vcyB9Vogw2yGH9 rR4Ai4mtbtsyu4i42y8+tKbIfIvx/Ttk7oMcQuXlPud3wFpgUGpnVDr3D/P7g4F+sS6Y bcQn129efCsMXivE1JZW6Cr8usIuJ23bw/kIckPu2ZlvSgDyXaFTbXM1TVZKJQ6njKi/ /QseYXe5AZBOdCR7nM8SlCL+zEbAugFAIxxt50w3ZtOFYlBBfgjV0opCwIlh5bd4QzuN QDPZqfhfNw4vGOfEE48kBNEmgBvUb+QPdbQG6klP/rdXChVlh/iBC6frCWy2RZuHT1J8 kgnQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 23si8528639ejg.238.2021.06.14.08.36.08; Mon, 14 Jun 2021 08:36:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233604AbhFNPft (ORCPT + 99 others); Mon, 14 Jun 2021 11:35:49 -0400 Received: from verein.lst.de ([213.95.11.211]:45003 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232985AbhFNPfp (ORCPT ); Mon, 14 Jun 2021 11:35:45 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 4E32868AFE; Mon, 14 Jun 2021 17:33:39 +0200 (CEST) Date: Mon, 14 Jun 2021 17:33:39 +0200 From: Christoph Hellwig To: Tianyu Lan Cc: Christoph Hellwig , kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, arnd@arndb.de, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, kirill.shutemov@linux.intel.com, rppt@kernel.org, hannes@cmpxchg.org, cai@lca.pw, krish.sadhukhan@oracle.com, saravanand@fb.com, Tianyu.Lan@microsoft.com, konrad.wilk@oracle.com, m.szyprowski@samsung.com, robin.murphy@arm.com, boris.ostrovsky@oracle.com, jgross@suse.com, sstabellini@kernel.org, joro@8bytes.org, will@kernel.org, xen-devel@lists.xenproject.org, davem@davemloft.net, kuba@kernel.org, jejb@linux.ibm.com, martin.petersen@oracle.com, iommu@lists.linux-foundation.org, linux-arch@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, netdev@vger.kernel.org, vkuznets@redhat.com, thomas.lendacky@amd.com, brijesh.singh@amd.com, sunilmut@microsoft.com Subject: Re: [RFC PATCH V3 10/11] HV/Netvsc: Add Isolation VM support for netvsc driver Message-ID: <20210614153339.GB1741@lst.de> References: <20210530150628.2063957-1-ltykernel@gmail.com> <20210530150628.2063957-11-ltykernel@gmail.com> <20210607065007.GE24478@lst.de> <279cb4bf-c5b6-6db9-0f1e-9238e902c8f2@gmail.com> <20210614070903.GA29976@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 14, 2021 at 10:04:06PM +0800, Tianyu Lan wrote: > The pages in the hv_page_buffer array here are in the kernel linear > mapping. The packet sent to host will contain an array which contains > transaction data. In the isolation VM, data in the these pages needs to be > copied to bounce buffer and so call dma_map_single() here to map these data > pages with bounce buffer. The vmbus has ring buffer where the send/receive > packets are copied to/from. The ring buffer has been remapped to the extra > space above shared gpa boundary/vTom during probing Netvsc driver and so > not call dma map function for vmbus ring > buffer. So why do we have all that PFN magic instead of using struct page or the usual kernel I/O buffers that contain a page pointer?