Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 14 Jun 2021 17:17:30 +0100
From:   Matthew Wilcox <willy@infradead.org>
To:     Christoph Hellwig <hch@lst.de>
Cc:     Andrew Morton <akpm@linux-foundation.org>, Jan Kara <jack@suse.cz>,
        Al Viro <viro@zeniv.linux.org.uk>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: remove the implicit .set_page_dirty default
Message-ID: <YMeBGiaQUHWeKEFC@casper.infradead.org>
References: <20210614061512.3966143-1-hch@lst.de>
 <YMdKOst/Psnlxh8a@casper.infradead.org>
 <20210614155333.GB2413@lst.de>
 <20210614155530.GA2563@lst.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210614155530.GA2563@lst.de>
Precedence: bulk

On Mon, Jun 14, 2021 at 05:55:30PM +0200, Christoph Hellwig wrote:
> On Mon, Jun 14, 2021 at 05:53:33PM +0200, Christoph Hellwig wrote:
> > On Mon, Jun 14, 2021 at 01:23:22PM +0100, Matthew Wilcox wrote:
> > > i have a somewhat similar series in the works ...
> > > 
> > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/1e7e8c2d82666b55690705d5bbe908e31d437edb
> > > https://git.infradead.org/users/willy/pagecache.git/commitdiff/bf767a4969c0bc6735275ff7457a8082eef4c3fd
> > > 
> > > ... the other patches rather depend on the folio work.
> > 
> > Yes, these looks useful to me as well.
> 
> 
> And in fact I suspect the code in __set_page_dirty_no_writeback should
> really be the default if no ->set_page_dirty is set up.  It is the
> same code as the no-mapping case and really makes sense as the default
> case..

yes; i was even wondering if that should be conditional on one of the
"no writeback" bits in mapping ...